Fix empty list and empty dict handling
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty lists and empty dicts were not previously considered to be values. This caused the entire path to an empty list or dict to be ignored. JSON objects with or without empty list or dict values could cause jfpv1 hash collisions with similar objects up to version `0.12.2`. Any release beyond `v0.12.z` should be considered backward-incompatible for cases where empty lists or dicts are present. See the following issue for more details: #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty lists and empty dicts were not previously considered to be values. This caused the entire path to an empty list or dict to be ignored.
JSON objects with or without empty list or dict values could cause jfpv1 hash collisions with similar objects up to version
0.12.2. Any release beyondv0.12.zshould be considered backward-incompatible for cases where empty lists or dicts are present.See the following issue for more details:
#33