Skip to content
This repository has been archived by the owner on Oct 4, 2018. It is now read-only.

Do not show empty ad slots. #13

Closed
cobbdb opened this issue Nov 24, 2014 · 3 comments
Closed

Do not show empty ad slots. #13

cobbdb opened this issue Nov 24, 2014 · 3 comments

Comments

@cobbdb
Copy link
Owner

cobbdb commented Nov 24, 2014

If a slot has already had googletag.display called on it, then it should be exempt from future calls to show slot/breakpoint.

This should only apply to empty slots as filled slots may be legitimately shown/hidden. However empty slots will never want to be shown - only hidden.

There should also be a force setting to specifically override this default behavior and show an empty ad slot.

@cobbdb
Copy link
Owner Author

cobbdb commented May 20, 2016

Problem is:

  • show on slot => empty ad call => collapseEmptyDivs hides slot
  • hide on slot => noop
  • show on slot => display:block on empty slot

@cobbdb cobbdb modified the milestones: version 5, version 4 Jun 2, 2016
@cobbdb cobbdb removed this from the version 4 milestone Aug 4, 2016
@cobbdb
Copy link
Owner Author

cobbdb commented Aug 7, 2016

Breaking change as some applications may rely on this behavior.

@cobbdb cobbdb added the wontfix label Aug 8, 2016
@cobbdb
Copy link
Owner Author

cobbdb commented Aug 8, 2016

Show/Hide has always been an awkward and presumptuous part of Harmony. Instead of fixing this, I'm removing hide.slot() and hide.group() as well as show's display:block from version 6.

@cobbdb cobbdb closed this as completed Aug 8, 2016
@cobbdb cobbdb added this to the Version 6 milestone Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant