Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try except for mysterious FileNotFoundError with open #2365

Merged
merged 2 commits into from Jul 3, 2020

Conversation

brejoc
Copy link
Member

@brejoc brejoc commented Jun 26, 2020

Sometimes open seems to thrown the FileNotFoundError for no reason. The premission are right and the file actually gets created correctly. But there is still this error.

To prevent Cobbler from failing hard, I've implemented this retry.

This is a workaround for #2362

Sometimes `open` seems to thrown the FileNotFoundError for no reason.
The premission are right and the file actually gets created correctly.
But there is still this error.

To prevent Cobbler from failing hard, I've implemented this retry.
@brejoc
Copy link
Member Author

brejoc commented Jun 26, 2020

I still don't perceive this as a good solution, or a solution at all. The underlying problem still needs to be investigated.

@SchoolGuy SchoolGuy self-assigned this Jun 26, 2020
@SchoolGuy SchoolGuy added this to Pull Requests in Backlog via automation Jun 26, 2020
@SchoolGuy SchoolGuy linked an issue Jun 26, 2020 that may be closed by this pull request
@brejoc
Copy link
Member Author

brejoc commented Jun 26, 2020

Linting now has succeeded, but it seems like the results where not updated.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems as a lgtm fix for me. I know we should investigate the root cause but for now let's just merge this and fix it properly when more pressing matters are handled.

@brejoc
Copy link
Member Author

brejoc commented Jun 26, 2020

@SchoolGuy I'd be fine with that!

@Conan-Kudo Conan-Kudo merged commit acb9fa3 into master Jul 3, 2020
Backlog automation moved this from Pull Requests to Done Jul 3, 2020
@SchoolGuy SchoolGuy deleted the master-filenotfounderror-with-open branch October 24, 2020 09:55
@SchoolGuy SchoolGuy added this to the v3.2.0 milestone Oct 24, 2020
@SchoolGuy SchoolGuy removed this from Done in Backlog Oct 24, 2020
@SchoolGuy SchoolGuy added this to Pull Requests in V3.2.0 via automation Jun 29, 2021
@SchoolGuy SchoolGuy moved this from Pull Requests to ToDo in V3.2.0 Jun 29, 2021
@SchoolGuy SchoolGuy moved this from ToDo to Done in V3.2.0 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Errno 2] No such file or directory while writing system config
3 participants