Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust finding the children in utils.blender to new method #2666

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

SchoolGuy
Copy link
Member

Currently on master the cobbler import is broken because I did not adjust the way children are found in the correct way. This PR is the fix for the current problem.

@SchoolGuy SchoolGuy added the main Not a release but referring to the Git main branch label Jun 11, 2021
@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Jun 11, 2021
@SchoolGuy SchoolGuy requested a review from nodeg June 11, 2021 06:47
@SchoolGuy SchoolGuy added this to Pull Requests in Backlog via automation Jun 11, 2021
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the import works again.

$ cobbler import --name=centos83 --arch=x86_64 --path=/mnt2
task started: 2021-06-11_090512_import
task started (id=Media import, time=Fri Jun 11 09:05:12 2021)
running python triggers from /var/lib/cobbler/triggers/task/import/pre/*
running shell triggers from /var/lib/cobbler/triggers/task/import/pre/*
shell triggers finished successfully
import_tree; ['/mnt2', 'centos83', None, None, None]
importing from a network location, running rsync to fetch the files first
mkdir: /srv/www/cobbler/distro_mirror/centos83-x86_64
running: rsync -a  '/mnt2/' /srv/www/cobbler/distro_mirror/centos83-x86_64 --progress

received on stdout: sending incremental file list
received on stderr: 
Found a candidate signature: breed=redhat, version=rhel8
Found a matching signature: breed=redhat, version=rhel8
Adding distros from path /srv/www/cobbler/distro_mirror/centos83-x86_64:
creating new distro: centos83-x86_64
trying symlink: /srv/www/cobbler/distro_mirror/centos83-x86_64 -> /srv/www/cobbler/links/centos83-x86_64
running python triggers from /var/lib/cobbler/triggers/add/distro/pre/*
running shell triggers from /var/lib/cobbler/triggers/add/distro/pre/*
shell triggers finished successfully
mkdir: /srv/www/cobbler/images/centos83-x86_64
trying hardlink /srv/www/cobbler/distro_mirror/centos83-x86_64/images/pxeboot/vmlinuz -> /srv/www/cobbler/images/centos83-x86_64/vmlinuz
trying hardlink /srv/www/cobbler/distro_mirror/centos83-x86_64/images/pxeboot/initrd.img -> /srv/www/cobbler/images/centos83-x86_64/initrd.img
mkdir: /srv/tftpboot/images/centos83-x86_64
trying hardlink /srv/www/cobbler/distro_mirror/centos83-x86_64/images/pxeboot/vmlinuz -> /srv/tftpboot/images/centos83-x86_64/vmlinuz
trying hardlink /srv/www/cobbler/distro_mirror/centos83-x86_64/images/pxeboot/initrd.img -> /srv/tftpboot/images/centos83-x86_64/initrd.img
processing boot_files for distro: centos83-x86_64
skipping symlink, destination (/srv/www/cobbler/links/centos83-x86_64) exists
Writing template files for centos83-x86_64
running python triggers from /var/lib/cobbler/triggers/change/*
running python trigger cobbler.modules.scm_track
running python trigger cobbler.modules.managers.genders
running shell triggers from /var/lib/cobbler/triggers/change/*
shell triggers finished successfully
running python triggers from /var/lib/cobbler/triggers/add/distro/post/*
running shell triggers from /var/lib/cobbler/triggers/add/distro/post/*
shell triggers finished successfully
creating new profile: centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
running python triggers from /var/lib/cobbler/triggers/add/profile/pre/*
running shell triggers from /var/lib/cobbler/triggers/add/profile/pre/*
shell triggers finished successfully
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
running python triggers from /var/lib/cobbler/triggers/change/*
running python trigger cobbler.modules.scm_track
running python trigger cobbler.modules.managers.genders
running shell triggers from /var/lib/cobbler/triggers/change/*
shell triggers finished successfully
running python triggers from /var/lib/cobbler/triggers/add/profile/post/*
running shell triggers from /var/lib/cobbler/triggers/add/profile/post/*
shell triggers finished successfully
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
Added child "centos83-x86_64" to parent "centos83-x86_64"
associating repos
checking for rsync repo(s)
mkdir: /srv/www/cobbler/images/centos83-x86_64
mkdir: /srv/tftpboot/images/centos83-x86_64
find_items; ['']
find_items; ['distro']
find_items; ['']
find_items; ['distro']
processing boot_files for distro: centos83-x86_64
skipping symlink, destination (/srv/www/cobbler/links/centos83-x86_64) exists
Writing template files for centos83-x86_64
find_items; ['']
find_items; ['distro']
find_items; ['']
find_items; ['distro']
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
checking for rhn repo(s)
mkdir: /srv/www/cobbler/images/centos83-x86_64
mkdir: /srv/tftpboot/images/centos83-x86_64
find_items; ['']
find_items; ['distro']
find_items; ['']
find_items; ['distro']
processing boot_files for distro: centos83-x86_64
skipping symlink, destination (/srv/www/cobbler/links/centos83-x86_64) exists
Writing template files for centos83-x86_64
find_items; ['']
find_items; ['distro']
find_items; ['']
find_items; ['distro']
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
checking for yum repo(s)
starting descent into /srv/www/cobbler/distro_mirror/centos83-x86_64 for centos83-x86_64
processing repo at : /srv/www/cobbler/distro_mirror/centos83-x86_64/AppStream
need to process repo/comps: /srv/www/cobbler/distro_mirror/centos83-x86_64/AppStream
looking for /srv/www/cobbler/distro_mirror/centos83-x86_64/AppStream/repodata/*comps*.xml
Keeping repodata as-is :/srv/www/cobbler/distro_mirror/centos83-x86_64/AppStream/repodata
processing repo at : /srv/www/cobbler/distro_mirror/centos83-x86_64/BaseOS
need to process repo/comps: /srv/www/cobbler/distro_mirror/centos83-x86_64/BaseOS
looking for /srv/www/cobbler/distro_mirror/centos83-x86_64/BaseOS/repodata/*comps*.xml
Keeping repodata as-is :/srv/www/cobbler/distro_mirror/centos83-x86_64/BaseOS/repodata
mkdir: /srv/www/cobbler/images/centos83-x86_64
mkdir: /srv/tftpboot/images/centos83-x86_64
find_items; ['']
find_items; ['distro']
find_items; ['']
find_items; ['distro']
processing boot_files for distro: centos83-x86_64
skipping symlink, destination (/srv/www/cobbler/links/centos83-x86_64) exists
Writing template files for centos83-x86_64
find_items; ['']
find_items; ['distro']
find_items; ['']
find_items; ['distro']
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
Writing template files for centos83-x86_64
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
get_items; ['distro']
done with get_items; ['distro']
*** TASK COMPLETE ***

$ cobbler distro list
   centos83-x86_64
$ cobbler distro report
Name                           : centos83-x86_64
Architecture                   : x86_64
Automatic Installation Template Metadata : {'tree': 'http://@@http_server@@/cblr/links/centos83-x86_64'}
TFTP Boot Files                : {}
Boot loaders                   : ['grub']
Breed                          : redhat
Comment                        : 
Fetchable Files                : {}
Initrd                         : /srv/www/cobbler/distro_mirror/centos83-x86_64/images/pxeboot/initrd.img
Kernel                         : /srv/www/cobbler/distro_mirror/centos83-x86_64/images/pxeboot/vmlinuz
Kernel Options                 : {}
Kernel Options (Post Install)  : {}
Management Classes             : []
OS Version                     : rhel8
Owners                         : []
Redhat Management Key          : 
Remote Boot Initrd             : 
Remote Boot Kernel             : 
Template Files                 : {}

We should definitely get rid of the

get_items; ['distro']
done with get_items; ['distro']

log messages when importing. This is too verbose and very annoying.

@nodeg nodeg merged commit 149a711 into master Jun 11, 2021
Backlog automation moved this from Pull Requests to Done Jun 11, 2021
@SchoolGuy SchoolGuy deleted the fix-cobbler-import branch June 11, 2021 08:14
@SchoolGuy SchoolGuy removed this from Done in Backlog Jun 26, 2021
@SchoolGuy SchoolGuy added this to Pull Requests in V3.3.0 via automation Jun 26, 2021
@SchoolGuy SchoolGuy moved this from Pull Requests to Done in V3.3.0 Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main Not a release but referring to the Git main branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants