Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom Cobbler CLI and use the entry_points from setuptools #2748

Closed
wants to merge 3 commits into from

Conversation

SchoolGuy
Copy link
Member

Does what the title says

@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Aug 10, 2021
@SchoolGuy SchoolGuy requested a review from nodeg August 10, 2021 09:22
@SchoolGuy SchoolGuy added this to Pull Requests in V3.3.0 via automation Aug 10, 2021
@nodeg nodeg changed the title Remove custom Cobbler CLI and use the entry_points from from setuptools Remove custom Cobbler CLI and use the entry_points from setuptools Aug 10, 2021
…nal. Instead, add a new extras_require where they are named.
@SchoolGuy
Copy link
Member Author

Okay some requirement for the generated script is not matched in some environments. I will investigate but this is a good step for ensuring the setup is working which we didn't have before...

@nodeg nodeg marked this pull request as draft August 10, 2021 12:15
@nodeg nodeg removed this from Pull Requests in V3.3.0 Aug 10, 2021
@nodeg nodeg removed this from the v3.3.0 milestone Aug 10, 2021
@nodeg nodeg added this to To do in Backlog Aug 10, 2021
@nodeg nodeg moved this from To do to Inbox in Backlog Aug 10, 2021
@SchoolGuy
Copy link
Member Author

Okay so Leap 15.2 and Debian 10 do not include the Python distribution for mod_wsgi. This means when installing a packaged version of Cobbler this will fail. I am currently trying to fix this for Leap 15.3 but for Debian the only solution will be to do a pip install mod_wsgi. This is unfortunate but I don't see any other option which is doable. Removing mod_wsgi from the project requirements of pip is possible but in my eyes not a experience in case you forget to install it before installing Cobbler.

@SchoolGuy
Copy link
Member Author

Mail to the Debian Maintainers of Apache2-mod_wsgi was sent describing the problem.

@SchoolGuy
Copy link
Member Author

So I believe this PR is ready. When the SR to the SLE Codestream has gone through maintenance this will work. Nevertheless I do desire a positive response from the Debian folks to merge this.

@SchoolGuy
Copy link
Member Author

So the CLI will be developed seperatly in the mid-term future, thus the script I am removing will be obsolete anyway then. Using the same approach for cobblerd is very tempting since this is also just a very thin wrapper but it appears that we are not ready for this yet. Thus I will close this PR but won't delete the branch. Maybe when Debian and Leap have fixed it we can reopen this PR.

@SchoolGuy SchoolGuy closed this Aug 16, 2021
@SchoolGuy SchoolGuy removed this from Inbox in Backlog Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants