Use a real boolean instead of a str one in snippets #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2784 +/- ##
=======================================
Coverage 43.09% 43.09%
=======================================
Files 97 97
Lines 14079 14079
=======================================
Hits 6067 6067
Misses 8012 8012 Continue to review full report at Codecov.
|
SchoolGuy
changed the title
|
So my tests say this is working. Thus I will merge it now. If it is still broken we reopen the issue and try to fix it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2783
This PR adjusts the
autoinstall_doneandautoinstall_startsnippets to work as intended with the boolean values instead with string ones.