Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update virt docs and change the default virt type to kvm, bridge to v… #3505

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Update virt docs and change the default virt type to kvm, bridge to v… #3505

merged 1 commit into from
Mar 8, 2024

Conversation

opoplawski
Copy link
Contributor

…irbr0

Description

xen is mostly dead at this point. kvm is pretty much the standard now.

Behaviour changes

Old: Default virt type was xenpv and virt bridge xenbr0

New: Defauil virt type is kvm and virt bridge is virbr0

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • [ X Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@github-actions github-actions bot added documentation Improvements or additions to documentation API labels Nov 5, 2023
@SchoolGuy SchoolGuy self-requested a review November 5, 2023 14:55
SchoolGuy
SchoolGuy requested changes Nov 5, 2023
View reviewed changes
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for you changing this to a more reasonable default. I would appreciate if you could add a towncrier fragment for the changlog.

cobbler/items/system.py Outdated Show resolved Hide resolved
cobbler/remote.py Show resolved Hide resolved
@github-actions github-actions bot added the tests label Dec 4, 2023
@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Jan 12, 2024
@SchoolGuy SchoolGuy merged commit 00231c0 into cobbler:main Mar 8, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees
No one assigned
Labels
API documentation Improvements or additions to documentation tests
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@opoplawski @SchoolGuy