Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inst. prefix to kickstart kernel options #94

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

opoplawski
Copy link
Contributor

This is now required with EL9/Fedora and so kickstart fails to start without it.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (bfe837a) 4.10% compared to head (8e2f627) 4.09%.
Report is 6 commits behind head on main.

❗ Current head 8e2f627 differs from pull request most recent head 856a1a5. Consider uploading reports for the commit 856a1a5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #94      +/-   ##
========================================
- Coverage   4.10%   4.09%   -0.02%     
========================================
  Files         12      12              
  Lines       2144    2150       +6     
========================================
  Hits          88      88              
- Misses      2056    2062       +6     
Files Changed Coverage Δ
koan/app.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please stay compatible with old releases, as we did on Cobbler side as well.

@opoplawski
Copy link
Contributor Author

Okay, I've changed it to support the ancient releases as well.

@opoplawski opoplawski dismissed SchoolGuy’s stale review August 9, 2023 14:38

Changes have been made.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing my desired changes.

@SchoolGuy SchoolGuy merged commit 87fc322 into cobbler:main Aug 14, 2023
12 checks passed
@opoplawski
Copy link
Contributor Author

I'd like to get a new koan rpm out soon to fix this. Any chance we could get a new release out relatively soon? Any other issues that should get addressed as well?

@SchoolGuy
Copy link
Member

@opoplawski I will think about it and give you an answer by the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants