-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inst. prefix to kickstart kernel options #94
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
========================================
- Coverage 4.10% 4.09% -0.02%
========================================
Files 12 12
Lines 2144 2150 +6
========================================
Hits 88 88
- Misses 2056 2062 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please stay compatible with old releases, as we did on Cobbler side as well.
Okay, I've changed it to support the ancient releases as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing my desired changes.
I'd like to get a new koan rpm out soon to fix this. Any chance we could get a new release out relatively soon? Any other issues that should get addressed as well? |
@opoplawski I will think about it and give you an answer by the end of the week. |
This is now required with EL9/Fedora and so kickstart fails to start without it.