ClassCastException: LineTouchPointDescriptor cannot be cast to JumpTouchPointDescriptor

[nhnb]

I get the following ClassCastException with latest Cobertura git master on 4 files during instrumentation. All of them are static inner classes within interfaces, but this might be a coincidence.

[cobertura-instrument] java.lang.ClassCastException: net.sourceforge.cobertura.instrument.tp.LineTouchPointDescriptor cannot be cast to net.sourceforge.cobertura.instrument.tp.JumpTouchPointDescriptor


net.sourceforge.cobertura.instrument.tp.ClassMap.getCounterIdForJumpTrue
                  (ClassMap.java:204)
net.sourceforge.cobertura.instrument.pass3.InjectCodeTouchPointListener.beforeJump
                  (InjectCodeTouchPointListener.java:68)
net.sourceforge.cobertura.instrument.FindTouchPointsMethodAdapter.visitJumpInsn                   (FindTouchPointsMethodAdapter.java:246)
org.objectweb.asm.MethodVisitor.visitJumpInsn
org.objectweb.asm.tree.JumpInsnNode.accept
org.objectweb.asm.tree.InsnList.accept
org.objectweb.asm.tree.MethodNode.accept
org.objectweb.asm.util.CheckMethodAdapter$1.visitEnd
org.objectweb.asm.MethodVisitor.visitEnd
org.objectweb.asm.util.CheckMethodAdapter.visitEnd
org.objectweb.asm.ClassReader.b(Unknown Source)
org.objectweb.asm.ClassReader.accept(Unknown Source)
org.objectweb.asm.ClassReader.accept(Unknown Source)
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass
                  (CoberturaInstrumenter.java:204)
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass
                  (CoberturaInstrumenter.java:121)
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.addInstrumentationToSingleClass
                  (CoberturaInstrumenter.java:233)
net.sourceforge.cobertura.instrument.Main.addInstrumentationToSingleClass
                  (Main.java:274)
net.sourceforge.cobertura.instrument.Main.addInstrumentation(Main.java:283)
net.sourceforge.cobertura.instrument.Main.parseArguments(Main.java:373)
net.sourceforge.cobertura.instrument.Main.main(Main.java:395)

[nhnb]

.java and .class files to reproduce the issue with: http://filebin.ca/ndveXhpYQSw

[christ66]

I had no issues with instrumenting the 2 binary files provided. I tried creating a simple test case with multiple static inner classes, but can't reproduce.

We could always change the getCounterIdForJumpTrue and getCounterIdForJumpFalse methods to have an instanceof check to prevent a ClassCastException.

    public Integer getCounterIdForJumpTrue(int eventId) {
        if (eventId2touchPointDescriptor.get(eventId) instanceof JumpTouchPointDescriptor) {
            JumpTouchPointDescriptor jumpTouchPointDescriptor = (JumpTouchPointDescriptor) eventId2touchPointDescriptor
                    .get(eventId);
            if (jumpTouchPointDescriptor != null) {
                return jumpTouchPointDescriptor.getCounterIdForTrue();
            }
        }

        return null;
    }

[gronono]

I got the same error with the 2.0.2 version and java 7.
The underlying class have not inner classes. It has some annotations (service and override)

[ghost]

I also got the same error with java 7 and 2.0.1 version. What is estimated time for releasing 2.0.3 version.?

[christ66]

I just merged in a fix for this issue, can you check out the latest code:
git clone https://github.com/cobertura/cobertura
and run the command:
mvn package -DskipTests
and in the target folder there will be a snapshot version of the latest jar, could you test that jar and verify that this issue doesn't exist anymore?

[ghost]

sure, will let you know, thank you :)

[ghost]

I am not seeing this issue anymore. thank you

[D-Bugs]

There are the same issue for :

• getCounterIdForLineEventId
• getCounterIdForSwitch

[christ66]

I will make the same code changes to fix this also. Thanks for the heads up.