forked from mastodon/mastodon
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge indexes for reblog on statuses table (mastodon#5831)
We added an index for `[account_id, reblog_of_id]`, but we already have a similar index for `reblog_of_id`. Those index will be bigger according to statuses count. For example, `reblog_of_id` index uses 800MB for 10GB statuses table. So this patch swaps indexed columns like `[reblog_of_id, account_id]`, then it will covers both usage with single index. Since those index creation may take a while, I've also disabled previous index creation.
- Loading branch information
Showing
4 changed files
with
32 additions
and
6 deletions.
There are no files selected for viewing
12 changes: 9 additions & 3 deletions
12
db/migrate/20171122120436_add_index_account_and_reblog_of_id_to_statuses.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,12 @@ | ||
class AddIndexAccountAndReblogOfIdToStatuses < ActiveRecord::Migration[5.1] | ||
def change | ||
commit_db_transaction | ||
add_index :statuses, [:account_id, :reblog_of_id], algorithm: :concurrently | ||
disable_ddl_transaction! | ||
|
||
def up | ||
# This index has been superseded by migration 20171125185353 | ||
# add_index :statuses, [:account_id, :reblog_of_id], algorithm: :concurrently | ||
end | ||
|
||
def down | ||
remove_index :statuses, [:account_id, :reblog_of_id] if index_exists?(:statuses, [:account_id, :reblog_of_id]) | ||
end | ||
end |
7 changes: 7 additions & 0 deletions
7
db/migrate/20171125185353_add_index_reblog_of_id_and_account_to_statuses.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class AddIndexReblogOfIdAndAccountToStatuses < ActiveRecord::Migration[5.1] | ||
disable_ddl_transaction! | ||
|
||
def change | ||
add_index :statuses, [:reblog_of_id, :account_id], algorithm: :concurrently | ||
end | ||
end |
14 changes: 14 additions & 0 deletions
14
db/migrate/20171125190735_remove_old_reblog_index_on_statuses.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
class RemoveOldReblogIndexOnStatuses < ActiveRecord::Migration[5.1] | ||
disable_ddl_transaction! | ||
|
||
def up | ||
# This index may not exists (see migration 20171122120436) | ||
remove_index :statuses, [:account_id, :reblog_of_id] if index_exists?(:statuses, [:account_id, :reblog_of_id]) | ||
|
||
remove_index :statuses, :reblog_of_id | ||
end | ||
|
||
def down | ||
add_index :statuses, :reblog_of_id, algorithm: :concurrently | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters