Only process response if the request reached htmlmin #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 27, 2013 12:30
RequestMock always pretends that htmlmin has seen the request, so all other tests work normally.
|
@moeffju thank you! |
andrewsmedina
added a commit
that referenced
this pull request
Nov 28, 2013
Only process response if the request reached htmlmin
|
This fixes #53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django calls process_response for all middlewares, leading to performance problems with htmlmin in combination with a Cache middleware: the minified response is cached and delivered from cache, but minify still runs on it again.
This patch introduces a flag in the Request phase and checks it in the Response phase and only minifies when the request has also hit the middleware.