Fixed __eq__ not returning boolean value (#657)

cobrateam · Oct 19, 2018 · cec288b · cec288b
1 parent fc3c647
commit cec288b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/splinter/driver/djangoclient.py b/splinter/driver/djangoclient.py
@@ -55,6 +55,7 @@ def __eq__(self, other_object):
                 [(key, morsel.value) for key, morsel in self._cookies.items()]
             )
             return cookies_dict == other_object
+        return False
 
 
 class DjangoClient(LxmlDriver):

diff --git a/splinter/driver/flaskclient.py b/splinter/driver/flaskclient.py
@@ -55,7 +55,7 @@ def __eq__(self, other_object):
         if isinstance(other_object, dict):
             cookies_dict = dict([(c.name, c.value) for c in self._cookies.cookie_jar])
             return cookies_dict == other_object
-
+        return False
 
 class FlaskClient(LxmlDriver):
 

diff --git a/splinter/driver/webdriver/cookie_manager.py b/splinter/driver/webdriver/cookie_manager.py
@@ -62,3 +62,5 @@ def __eq__(self, other_object):
 
         if isinstance(other_object, dict):
             return dict(cookies) == other_object
+
+        return False
diff --git a/splinter/driver/zopetestbrowser.py b/splinter/driver/zopetestbrowser.py
@@ -57,6 +57,7 @@ def __contains__(self, key):
     def __eq__(self, other_object):
         if isinstance(other_object, dict):
             return dict(self.driver.cookies) == other_object
+        return False
 
 
 class ZopeTestBrowser(ElementPresentMixIn, DriverAPI):