Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing wait_time to Browser() #178

Closed
lorin opened this issue Nov 4, 2012 · 3 comments
Closed

Support passing wait_time to Browser() #178

lorin opened this issue Nov 4, 2012 · 3 comments
Assignees
@bernardobarreto

Comments

@lorin
Copy link
Contributor

lorin commented Nov 4, 2012

Currently, the BaseWebDriver class supports a wait_time argument in the init method, but this isn't passed in from any of the derived classes. So, if you want to set wait_time right now, you need to do:

browser = Browser('firefox')
browser.wait_time = 10

It would be nice if you could do:

browser = Browser('firefox', wait_time=10)
@bernardobarreto
Copy link
Member

+1

@bernardobarreto
Copy link
Member

I closed by mistake, sorry 💩

@andrewsmedina
Copy link
Member

👍

@ghost ghost assigned bernardobarreto Nov 25, 2012
lorin pushed a commit to lorin/splinter that referenced this issue Dec 9, 2012
Add wait_time arg to drive constructors
752a602 
Add support for specifying wait_time in constructors of BaseWebDriver subclasses.

This addresses issue cobrateam#178.
@lorin lorin mentioned this issue Dec 9, 2012
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernardobarreto bernardobarreto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewsmedina @lorin @bernardobarreto