Implemented Flask test client driver

[fgimian]

Hello there,

I've implemented a Flask test client driver heavily based on the provided Django driver. A lot of the code is shared between these modules, but I have kept them separate. Feel free to adjust this to taste 😄

I have replicated the Django tests and can confirm that all tests pass as shown below...

(splinter)fots@fotsies-ubprecise-01:~/splinter$ ./run_tests.py -w tests/test_flaskclient.py
................................................................................................................
----------------------------------------------------------------------
Ran 112 tests in 0.482s

OK

If you have any questions, please let me know 😄

Cheers
Fotis

[hltbra]

I think this should be inside an else block, because if cookies is an empty list, it's going to jump to this for line, and raise an AttributeError because list objects do not have .items() method.

[hltbra]

I see that webdriver's cookie manager has the same issue. You can skip this if you want and then we work on both issues together in a different PR.

[fgimian]

Well spotted, although I think that the main issue is the indent of the return statement. The return statement should be un-indented by one level because at present it only processes the first set of cookies in the list of dicts. In addition, moving the second for loop into an else block would be great for clarity.

e.g.

>>> def add(cookies):
...     if isinstance(cookies, list):
...         for cookie in cookies:
...             for key, value in cookie.items():
...                 print '%s: %s' % (key, value)
...             return
...
>>> add([
...     {'a': 'a1', 'b': 'b1'},
...     {'c': 'c1', 'd': 'd1'},
... ])
a: a1
b: b1
>>>

However as you said, this is an issue across a few of the drivers which would probably best be fixed with a single pull request 😄

[hltbra]

Thanks for the pull request, it looks very good! I am going to wait for more reviewers.

[fgimian]

Can't thank you enough for the detailed review, really appreciate it!! 👍

Cheers
Fotis

[fgimian]

This pull request has now been updated for Python 3 compatibility and is ready for merge 😄

Cheers
Fotis

[andrewsmedina]

I will create issues for the things highlighted by @hltbra. Then I will merge this PR.

[fgimian]

Sounds great! Please let me know if you need any help mate 😄

[andrewsmedina]

@fgimian and @hltbra thank you!

[fgimian]

Thank you so much, you've made my day! 😄