[TASK] Use GeneralUtility::getFileAbsFileName for resolving web assets #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to upcoming changes in typo3/cms-composer-installers v4.0.0 (currently available as RC1), composer packages are not linked anymore to public folder typo3conf/ext/extension_name/. As a result, web assets need to be resolved accordingly, see https://github.com/TYPO3/CmsComposerInstallers/releases/tag/v4.0.0-RC1 In this particular scenario the change is simple, but (now) with a corresponding distinction between "extension path" and "public extension resources path": * `PathUtility::getAbsoluteWebPath('EXT:extension_name/')` resolves to corresponding (private) folder in Composer `vendor/` folder * `PathUtility::getAbsoluteWebPath('EXT:extension_name/Resources/Public')` resolves to (virtual) public path `typo3conf/ext/` Fixes: https://forge.typo3.org/issues/96374
|
Thanks a lot for going all the way and submitting a PR. Just a question: is the change compatible with TYPO3 v10, since the current branch of the extension covers both 10 and 11? |
Yes, it does & I just verified that as well in a local TYPO3 v10 installation. |
|
Thanks for having verified! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to upcoming changes in typo3/cms-composer-installers v4.0.0
(currently available as RC1), composer packages are not linked
anymore to public folder typo3conf/ext/extension_name/.
As a result, web assets need to be resolved accordingly, see
https://github.com/TYPO3/CmsComposerInstallers/releases/tag/v4.0.0-RC1
In this particular scenario the change is simple, but (now) with
a corresponding distinction between "extension path" and "public
extension resources path":
PathUtility::getAbsoluteWebPath('EXT:extension_name/')resolvesto corresponding (private) folder in Composer
vendor/folderPathUtility::getAbsoluteWebPath('EXT:extension_name/Resources/Public')resolves to (virtual) public path
typo3conf/ext/Fixes: https://forge.typo3.org/issues/96374