Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation Script #5

Merged
merged 5 commits into from Aug 22, 2013
Merged

Installation Script #5

merged 5 commits into from Aug 22, 2013

Conversation

pseudomuto
Copy link
Contributor

Saw a TODO and thought I'd give 'er!

I moved the main script into the bin folder, created install.sh and updated the README file with instructions. The result...you can install/update with CURL and run by typing octocatsay <message> from a shell.

@cobyism
Copy link
Owner

cobyism commented Aug 19, 2013

@pseudomuto ❤️ thanks for taking the time to work this up!

Is depending on Git a good thing? I feel like this is something that’s quick and fun and might be something people want to install for someone else who may not have Git installed or available. Maybe if it just used curl or something to pull the script and overwrite it each time if it exists that might be simpler and more dependable? I don’t really know and don’t want really want to overthink this, but what are your thoughts?

@pseudomuto
Copy link
Contributor Author

You're probably right...depending on Git is not great. I was only thinking of developers when I was tinkering with the install script.

I think I change it fairly easily...more commits coming!

@cobyism
Copy link
Owner

cobyism commented Aug 19, 2013

🤘 Awesome!

@pseudomuto
Copy link
Contributor Author

@cobyism I removed the dependency on git here. Now the installation copies the file (using curl) and overwrites it each time rather than maintaining a repo.

What do you think?

@cobyism
Copy link
Owner

cobyism commented Aug 22, 2013

Wicked, thanks for that change. Let’s roll with it and see how it goes 😄 Thanks for taking the time to have a stab at this ⚡ ✨

cobyism pushed a commit that referenced this pull request Aug 22, 2013
@cobyism cobyism merged commit 4223980 into cobyism:master Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants