Fix off-by-one

coc-extensions · Sep 1, 2018 · c3fa12b · c3fa12b
1 parent b0acc4e
commit c3fa12b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/FSharpLanguageServer/Program.fs b/src/FSharpLanguageServer/Program.fs
@@ -635,7 +635,7 @@ type Server(client: ILanguageClient) =
                 let file = FileInfo(p.textDocument.uri.LocalPath)
                 let! c = checkOpenFile(file, true, false)
                 let line = lineContent(file, p.position.line)
-                let maybeId = QuickParse.GetCompleteIdentifierIsland false line (p.position.character - 1)
+                let maybeId = QuickParse.GetCompleteIdentifierIsland false line (p.position.character)
                 match c, maybeId with 
                 | Error(errors), _ -> 
                     dprintfn "Check failed, ignored %d errors" (List.length(errors))

diff --git a/tests/FSharpLanguageServer.Tests/ServerTests.fs b/tests/FSharpLanguageServer.Tests/ServerTests.fs
@@ -189,6 +189,20 @@ let ``hover over function``() =
     | None -> Assert.Fail("No hover")
     | Some hover -> if List.isEmpty hover.contents then Assert.Fail("Hover list is empty")
 
+[<Test>]
+let ``hover over left edge``() = 
+    let client, server = createServerAndReadFile("MainProject", "Hover.fs")
+    match server.Hover(textDocumentPosition("MainProject", "Hover.fs", 3, 13)) |> Async.RunSynchronously with 
+    | None -> Assert.Fail("No hover")
+    | Some hover -> if List.isEmpty hover.contents then Assert.Fail("Hover list is empty")
+
+[<Test>]
+let ``hover over right edge``() = 
+    let client, server = createServerAndReadFile("MainProject", "Hover.fs")
+    match server.Hover(textDocumentPosition("MainProject", "Hover.fs", 3, 17)) |> Async.RunSynchronously with 
+    | None -> Assert.Fail("No hover")
+    | Some hover -> if List.isEmpty hover.contents then Assert.Fail("Hover list is empty")
+
 [<Test>]
 let ``hover over qualified name``() = 
     let client, server = createServerAndReadFile("MainProject", "Hover.fs")