Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Move ubuntu-stable to noble devel series #6048

Merged
merged 3 commits into from Mar 13, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Mar 8, 2024

The current devel series will become 24.04 LTS, thus a major/important release again. Let's avoid repeating a regression catastrophe like 23.10 mantic, and start testing on it early, so that we have a chance to fix up everything by the final release.

I created a calendar reminder for me on Apr 25 to revert the hack and enable -proposed.

@martinpitt martinpitt added the bot label Mar 8, 2024
@cockpituous cockpituous changed the title images: Move ubuntu-stable to noble devel series WIP: 27e09983b1f1: [no-test] images: Move ubuntu-stable to noble devel series Mar 8, 2024
@cockpituous cockpituous changed the title WIP: 27e09983b1f1: [no-test] images: Move ubuntu-stable to noble devel series images: Move ubuntu-stable to noble devel series Mar 8, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title images: Move ubuntu-stable to noble devel series WIP: 7c453a055cc5: [no-test] images: Move ubuntu-stable to noble devel series Mar 8, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 7c453a055cc5: [no-test] images: Move ubuntu-stable to noble devel series images: Move ubuntu-stable to noble devel series Mar 8, 2024
@martinpitt
Copy link
Member Author

openssh install is broken. Need to report to launchpad (didn't find it quickly), and block.

@cockpituous cockpituous changed the title images: Move ubuntu-stable to noble devel series WIP: 861be928e4c7: [no-test] images: Move ubuntu-stable to noble devel series Mar 11, 2024
@martinpitt martinpitt self-assigned this Mar 11, 2024
@martinpitt martinpitt removed the bot label Mar 11, 2024
@martinpitt martinpitt changed the title WIP: 861be928e4c7: [no-test] images: Move ubuntu-stable to noble devel series images: Move ubuntu-stable to noble devel series Mar 11, 2024
@martinpitt martinpitt added the bot label Mar 11, 2024
@cockpituous cockpituous changed the title images: Move ubuntu-stable to noble devel series WIP: f9614fea17d7: [no-test] images: Move ubuntu-stable to noble devel series Mar 11, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: f9614fea17d7: [no-test] images: Move ubuntu-stable to noble devel series images: Move ubuntu-stable to noble devel series Mar 11, 2024
@cockpituous
Copy link
Contributor

@martinpitt
Copy link
Member Author

machines failures: Most are due to a single AppArmor denial:

apparmor="DENIED" operation="open" class="file" profile="virt-aa-helper" name="/etc/gnutls/config" pid=1537 comm="virt-aa-helper" requested_mask="r" denied_mask="r" fsuid=0 ouid=0

This wasn't reported yet, so I sent https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/2056739 .

The other failures are because ubuntu-stable now supports external snapshots. I'll think about how to adjust the tests to work without a lockstep change.

martinpitt added a commit to martinpitt/cockpit-machines that referenced this pull request Mar 11, 2024
In cockpit-project/bots#6048 we are moving
the "ubuntu-stable" image from 23.04 to 24.04 LTS. Until that lands, our
tests need to get along with both releases to avoid a lockstep PR.

Therefore, temporarily introduce a dynamic runtime check which release
we are running on, and thus whether it supports external snapshots. Once
that bots PR lands, we can re-simplify this to a static name condition
again.
@martinpitt martinpitt added blocked and removed bot labels Mar 11, 2024
martinpitt added a commit to cockpit-project/cockpit-machines that referenced this pull request Mar 11, 2024
In cockpit-project/bots#6048 we are moving
the "ubuntu-stable" image from 23.04 to 24.04 LTS. Until that lands, our
tests need to get along with both releases to avoid a lockstep PR.

Therefore, temporarily introduce a dynamic runtime check which release
we are running on, and thus whether it supports external snapshots. Once
that bots PR lands, we can re-simplify this to a static name condition
again.
@martinpitt
Copy link
Member Author

martinpitt commented Mar 11, 2024

Cockpit fails very often on

apparmor="DENIED" operation="open" class="file" profile="/usr/sbin/chronyd" name="/etc/gnutls/config" pid=885 comm="chronyd" requested_mask="r" denied_mask="r" fsuid=0 ouid=0

which is very similar to https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/2056739. Filed as https://bugs.launchpad.net/ubuntu/+source/chrony/+bug/2056747

Others are known naughties.

This leaves just two specific failures:

@martinpitt martinpitt force-pushed the u-stable-noble branch 3 times, most recently from 77e2f88 to b465e9b Compare March 11, 2024 12:58
martinpitt and others added 3 commits March 12, 2024 16:14
The current devel series will become 24.04 LTS, thus a major/important
release again. Let's avoid repeating a regression catastrophe like 23.10
mantic, and start testing on it early, so that we have a chance to fix
up everything by the final release.

Disable -proposed for noble, as that has all the broken bits.

Add message filters for AppArmor regressions, and copy naughties which
now apply to 24.04.
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jelly jelly merged commit 7f61a62 into cockpit-project:main Mar 13, 2024
11 checks passed
@martinpitt martinpitt deleted the u-stable-noble branch March 13, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants