-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
I just found cockpit-project/starter-kit/pull/554 |
Sure please do. Also tests failed massively. https://cockpit-logs.us-east-1.linodeobjects.com/pull-127-20230413-135933-8db042fc-fedora-38/log.html does it compile locally? |
Yes it compiles locally with Could it be the same reason here? |
Yes, it could -- we updated the cockpit/tasks container yesterday, which pulled in a new chromium. I'm 90% sure that it already fails on master now due to that. This needs a new chrome-remote-interface, like we already did to our other projects. Thank you! |
Yes, after bumping chrome-remote-interface, tests seem to pass locally without any "CDP Broken" error. I'll send a PR fixing it first :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now, thank you! Let's still fix the TF fedora-37 failure, but you said you wanted to do this, right?
Update ESLint and all it's plugins.
Synced
.eslintrc.json
with cockpit-machines and cockpit-podman. And fixed errors accordingly.