Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Update to eslint 8 #127

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Update to eslint 8 #127

merged 5 commits into from
Apr 14, 2023

Conversation

subhoghoshX
Copy link
Member

Update ESLint and all it's plugins.

Synced .eslintrc.json with cockpit-machines and cockpit-podman. And fixed errors accordingly.

@KKoukiou KKoukiou requested review from skobyda and KKoukiou and removed request for skobyda April 13, 2023 13:59
@subhoghoshX
Copy link
Member Author

I just found cockpit-project/starter-kit/pull/554 eslint-plugin-standard is dropped because it is deprecated. May I do the same here?

@KKoukiou
Copy link
Contributor

I just found cockpit-project/starter-kit/pull/554 eslint-plugin-standard is dropped because it is deprecated. May I do the same here?

Sure please do. Also tests failed massively. https://cockpit-logs.us-east-1.linodeobjects.com/pull-127-20230413-135933-8db042fc-fedora-38/log.html does it compile locally?

@subhoghoshX
Copy link
Member Author

Yes it compiles locally with npm run build. I recognize the CDP Broken error that you helped me fix once. I remember it was because of outdated chrome-remote-interface (https://github.com/cockpit-project/cockpit-certificates/blob/master/package.json#L21)

Could it be the same reason here?

@martinpitt
Copy link
Member

Yes, it could -- we updated the cockpit/tasks container yesterday, which pulled in a new chromium. I'm 90% sure that it already fails on master now due to that. This needs a new chrome-remote-interface, like we already did to our other projects. Thank you!

@subhoghoshX
Copy link
Member Author

Yes, after bumping chrome-remote-interface, tests seem to pass locally without any "CDP Broken" error.

I'll send a PR fixing it first :)

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now, thank you! Let's still fix the TF fedora-37 failure, but you said you wanted to do this, right?

@martinpitt martinpitt merged commit 38ae48d into cockpit-project:master Apr 14, 2023
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants