Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream gating tests on RHEL 9 #128

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

martinpitt
Copy link
Member

There are a lot of failures in current RHEL 9, most of them rather weird:

# testDetachDisk (__main__.TestMachinesDisks)
Traceback (most recent call last):
  File "/usr/lib64/python3.9/unittest/case.py", line 550, in _callTestMethod
    method()
  File "/ARTIFACTS/work-upstreamF2UGhr/plans/upstream/discover/default/tests/test/check-machines-disks", line 810, in testDetachDisk
    m.execute("virsh attach-disk --domain subVmTest1 --source {0}/mydiskofpoolone_2 --target vdd --targetbus virtio --persistent".format(p1))
  File "/ARTIFACTS/work-upstreamF2UGhr/plans/upstream/discover/default/tests/bots/machine/machine_core/ssh_connection.py", line 322, in execute
    ret = select.select(rset, wset, [], 10)
  File "/ARTIFACTS/work-upstreamF2UGhr/plans/upstream/discover/default/tests/bots/machine/machine_core/timeout.py", line 41, in handle_timeout
    raise RuntimeError(self.error_message)
RuntimeError: Timed out on 'virsh attach-disk --domain subVmTest1 --source /var/lib/cockpittest/vm_one/mydiskofpoolone_2 --target vdd --targetbus virtio --persistent'
[0422/092906.620137:WARNING:headless_browser_main_parts.cc(83)] Cannot create Pref Service with no user data dir.

DevTools listening on ws://127.0.0.1:9430/devtools/browser/ba9c75fc-dd2c-4720-a11b-9ed54c52208e
/ARTIFACTS/work-upstreamF2UGhr/plans/upstream/discover/default/tests/test/common/chromium-cdp-driver.js:242
        throw Error(`Frame ${frame} is unknown`);

I can actually reproduce this with

bots/vm-run rhel-9-0
tmt run --all provision --how connect -g c

but I can't make much sense of it. I did see that the memory gets really tight. I propose to go with this reduced test set for now, and slowly build this back up.

There is also a few additional commits which fix the test setup for the above "run this locally" scenario.

There is no EPEL for RHEL 9 yet. The setup script already explicitly
installs epel-release version 8, but its repo files still contain
`$releasever`. Pin that to "8" as well, so that installing chromium
actually works.
test/common/fmf_metadata/base.py imports that.
Some tests regularly kill the RHEL 9 gating instances (which also run on
the testing farm) due to running out of memory and crashing the browser.

Thus run the same set of representative tests as on Fedora.
@martinpitt martinpitt changed the title Fix tests on RHEL 9 Fix downstream gating tests on RHEL 9 Apr 23, 2021
@martinpitt
Copy link
Member Author

martinpitt commented Apr 23, 2021

I did a downstream test run and it succeeded 🥳 (direct TF log)

Our own tests fail due to testNICEdit, issue #127 .

@KKoukiou KKoukiou merged commit 4bcb3ec into cockpit-project:main Apr 23, 2021
@KKoukiou KKoukiou deleted the rhel-9-tests branch April 23, 2021 09:34
@martinpitt martinpitt restored the rhel-9-tests branch April 23, 2021 09:37
@martinpitt martinpitt deleted the rhel-9-tests branch April 23, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants