Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: Update @patternfly/react-console #884

Merged
merged 2 commits into from
Dec 8, 2022
Merged

package.json: Update @patternfly/react-console #884

merged 2 commits into from
Dec 8, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 8, 2022

No description provided.

@github-actions github-actions bot added the bot label Dec 8, 2022
@github-actions github-actions bot changed the title [no-test] package.json: Update @patternfly/react-console package.json: Update @patternfly/react-console Dec 8, 2022
github-actions bot pushed a commit that referenced this pull request Dec 8, 2022
package.json: Update @patternfly/react-console
a8ec9e1 
Closes #884
@github-actions github-actions bot force-pushed the npm-update-patternfly-react-console-20221208-153932 branch from 54f21bb to a8ec9e1 Compare December 8, 2022 15:39
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 8, 2022

Please manually check features related to these files:

package.json:    "@patternfly/react-console": "4.93.10",
src/components/vm/consoles/consoles.jsx:import { AccessConsoles } from "@patternfly/react-console";
src/components/vm/consoles/desktopConsole.jsx:import { DesktopViewer } from '@patternfly/react-console';
src/components/vm/consoles/vnc.jsx:import { VncConsole } from '@patternfly/react-console';

allisonkarlitskaya pushed a commit that referenced this pull request Dec 8, 2022
package.json: Update @patternfly/react-console
2b86395 
Closes #884
@allisonkarlitskaya allisonkarlitskaya force-pushed the npm-update-patternfly-react-console-20221208-153932 branch from a8ec9e1 to 2b86395 Compare December 8, 2022 15:40
@martinpitt martinpitt mentioned this pull request Dec 8, 2022
Closed
1 task
@martinpitt
Copy link
Member

Hmm, tests look very messy here -- unrelated to react-console, but perhaps due to some other npm updates that rode along? One round of retry to compare.

arch, debian-stable, f36, f36/firefox

@martinpitt
Copy link
Member

and "protection checks" need the same treatment as cockpit-project/cockpit-podman#1158

@martinpitt
Copy link
Member

The pixel test diffs seem real. But glad to see that the console crash seems fixed, thanks @KKoukiou !

@KKoukiou
Copy link
Collaborator

KKoukiou commented Dec 8, 2022

The pixel test diffs seem real. But glad to see that the console crash seems fixed, thanks @KKoukiou !

The pixel test diff on the External console test is valid, some info were added for Suse how to launch virt-viewer.
The rest is weird noise because of irrelevant packages getting updated. Do you think the package.json diff is normal here?

KKoukiou pushed a commit to KKoukiou/cockpit-machines that referenced this pull request Dec 8, 2022
@KKoukiou
package.json: Update @patternfly/react-console
b6082bb 
Closes cockpit-project#884
KKoukiou pushed a commit that referenced this pull request Dec 8, 2022
@KKoukiou
package.json: Update @patternfly/react-console
6de36d1 
Closes #884
@KKoukiou KKoukiou force-pushed the npm-update-patternfly-react-console-20221208-153932 branch from 2b86395 to 6de36d1 Compare December 8, 2022 20:29
@KKoukiou KKoukiou force-pushed the npm-update-patternfly-react-console-20221208-153932 branch from 6de36d1 to 93dd3a5 Compare December 8, 2022 20:43
@KKoukiou
.github: run protection checks on Ubuntu 20.04
53dc53a 
The podman version (3.4.4) on Ubuntu 22.04 has issues with pipes and
stops before piping the full tarball over (at ~ 25M of ~ 250M). This
makes the protection checks fail, which means we can't land node_modules
updates. For now pin it to 20.04 until we figured out the issue on
22.04.
@martinpitt
Copy link
Member

pixel review diff -- so the gap between a numeric input and the unit got smaller. I liked the previous version a bit better, but I suppose this isn't the place to second-guess PF updates.

The failed protection checks are expected -- that workflow runs from main. I have a lot of faith that the fix will work, we can ignore the failure here.

still some failures here though -- retrying.

Thank you!

@martinpitt
Copy link
Member

It seems rawhide has a regression with iSCSI:

error: Failed to start pool iscsi-pool
error: internal error: Failed to get host number for iSCSI session with path '/sys/class/iscsi_session/session1/device'

But I'll let this slip here, let's investigate that separately. Thanks!

@martinpitt martinpitt merged commit 72d2121 into main Dec 8, 2022
@martinpitt martinpitt deleted the npm-update-patternfly-react-console-20221208-153932 branch December 8, 2022 21:50
martinpitt pushed a commit that referenced this pull request Dec 8, 2022
@martinpitt
package.json: Update @patternfly/react-console
00082b7 
Closes #884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinpitt @KKoukiou