Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum cpu-shares is 2 #287

Closed
marusak opened this issue Jan 9, 2020 · 0 comments · Fixed by #289
Closed

Minimum cpu-shares is 2 #287

marusak opened this issue Jan 9, 2020 · 0 comments · Fixed by #289

Comments

@marusak
Copy link
Member

marusak commented Jan 9, 2020

We enable to go down to 0, which is invalid. The minimum value is 2.
I am opening issue, since the default is also 1024 and not 0 as we have not set up, but podman behaves a bit differently - see containers/podman#4822 for discussion.
Once this discussion is resolved, I'll fix both of these issues in our code.
marusak added a commit to marusak/cockpit-podman that referenced this issue Jan 10, 2020
@marusak
Fix default and minimum value for CPU Shares
02fb852 
Minimum value is 2.
Default value is 1024. We still test that if we don't set it up, it is
0, but for that see containers/podman#4822

Fixes cockpit-project#287
@marusak marusak mentioned this issue Jan 10, 2020
Merged
marusak added a commit to marusak/cockpit-podman that referenced this issue Jan 10, 2020
@marusak
Fix default and minimum value for CPU Shares
6ccb0a9 
Minimum value is 2.
Default value is 1024. We still test that if we don't set it up, it is
0, but for that see containers/podman#4822

Fixes cockpit-project#287
marusak added a commit to marusak/cockpit-podman that referenced this issue Jan 13, 2020
@marusak
Fix default and minimum value for CPU Shares
0f6d5c4 
Minimum value is 2.
Default value is 1024. We still test that if we don't set it up, it is
0, but for that see containers/podman#4822

Fixes: cockpit-project#287
Closes: cockpit-project#289
marusak added a commit that referenced this issue Jan 13, 2020
@marusak
Fix default and minimum value for CPU Shares
0185702 
Minimum value is 2.
The default value is 1024 (or value set up in cgroups).
Let's not assume any value. Also podman reports `0` as default. We still test that if we don't set it up, it is 0, but for that see containers/podman#4822

Fixes: #287
Closes: #289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix default and minimum value for CPU Shares marusak/cockpit-podman
1 participant
@marusak