Keep .spec in git

[martinpitt]

Give up on .spec.in and directly keep the .spec in git. This aligns a
lot better with what packit wants to do, and avoids having explicit
post-upstream-clone: actions.

We still want to build tarballs with a correct .spec (for using with
rpmbuild -bb and VM image preparation), so make sure that they get the
patched file.

• fix or work around srpm fails when spec file is not in the project root dir and there is a custom create-archive: action packit/packit#1621
• fix or work around SRPM cannot be created in Copr when packaging files are in a subdir packit/packit#1637
• Test release on my fork

[martinpitt]

packit srpm failed with this:

ValueError: '/tmp/tmp48d6s1r0/cockpit-podman-49.1.5.gaedec28.tar.xz' is not in the subpath of '/tmp/tmp48d6s1r0/packaging' OR one path is relative and the other is absolute.

It already failed the same way in my previous attempt when I dropped specfile_path:. I put that back as I thought it might maybe require it (even though the docs say that it's optional), but that didn't help.

@lachmanfrantisek, @TomasTomecek : What am I doing wrong here? This PR is actually meaning to go towards the approach that packit wants, i.e. we want to reduce our packit.yaml. I.e. I'm happy to structure this otherwise, in some "that's the standard way". Thank you in advance!

[martinpitt]

I changed the approach to not leave the generated .spec file in the tree, it might confuse packit.

[martinpitt]

Nope, still won't budge. Somehow packit really doesn't like a spec file which is not in the project root dir?

[martinpitt]

See https://github.com/packit/packit-service/issues/1511 -- there's a bug that propose-downstream fails without an explicit specfile_path:, so we'll most likely have to bring that back anyway (with a bug ref). That will surface when testing the releasing, but until then we first need to sort out the packit srpm build.

[martinpitt]

Same issue in cockpit-project/cockpit#17450. I can reproduce this locally with packit srpm, will have a look after lunch.

[martinpitt]

@lachmanfrantisek, @TomasTomecek : Isolated, reproduced, filed packit/packit#1621 about it.

[martinpitt]

Still fails srpm build, I followed up to packit/packit#1621

[martinpitt]

The packit issue was fixed, so let's try this again.

[martinpitt]

Argh, this is still broken. I can reproduce this locally:

❱❱❱ packit srpm
2022-08-31 17:37:51.075 command_handler.py INFO   Nothing to clean.
2022-08-31 17:37:51.075 utils.py          ERROR  Preparation of the repository for creation of an SRPM failed: Specfile /var/home/martin/upstream/cockpit-podman/cockpit-podman.spec not found on ref spec.

So it seems that once again violates the "Else recursively search the tree and use the first spec file found." documentation.

❱❱❱ find -name '*.spec'
./packaging/cockpit-podman.spec

[martinpitt]

Not important, and not worth the hassle.