test: Work around leaking podman processes and broken API after idle timeout #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added a commit
to martinpitt/cockpit-podman
that referenced
this pull request
Jul 31, 2020
Stopping podman.service often leaves processes behind, due to the broken `KillMode=process`. This was fixed upstream, but is not in a release yet. Also fix the unit type, to avoid a forever-hanging "activating" state. This is also already fixed in upstream master. Closes cockpit-project#473
|
Much much better! Still breaks testNotRunning But also, I lied in that commit -- it's not really a race condition in podman.service, the socket is already handed over correctly. With curl it works reliably all the time. I also don't get that error interactively, it works. So there must be something more subtle going on. |
martinpitt
added a commit
to martinpitt/cockpit-podman
that referenced
this pull request
Jul 31, 2020
Stopping podman.service often leaves processes behind, due to the broken `KillMode=process`. This was fixed upstream, but is not in a release yet. Also fix the unit type, to avoid a forever-hanging "activating" state. This is also already fixed in upstream master. Closes cockpit-project#473
Stopping podman.service often leaves processes behind, due to the broken `KillMode=process`. This was fixed upstream, but is not in a release yet. Also fix the unit type, to avoid a forever-hanging "activating" state. This is also already fixed in upstream master.
martinpitt
changed the title
|
I finally have this working on my local system now, let's see what CI says to that. Now I will try to find CLI reproducers for these problems, and report them upstream. |
1 task
|
Hooray, I finally understand the madness that's going on here: containers/podman#7180 (comment) |
martinpitt
changed the title
Working with user podman API leaves behind a `podman pause` process which is not attached to/stopped by podman.service. This completely breaks the API: containers/podman#7180 Closes cockpit-project#473
|
Alas, that was a hard one. In hindsight it's pretty obvious, but I got led astray in so many different wrong directions here.. @marusak, this is ready for review. 🎉 |
marusak
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.