Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debian/Ubuntu install instructions #64

Merged
merged 2 commits into from
Apr 4, 2017

Conversation

martinpitt
Copy link
Member

Show more secure key ID and fingerprint (verified on master key on the release machine), and drop obsolete systemctl enable/start commands.

martinpitt added a commit to martinpitt/cockpit-project.github.io that referenced this pull request Apr 4, 2017
The cockpit package has done this automatically for quite some time.

Closes cockpit-project#64
running.html Outdated
<pre>sudo apt-key adv --keyserver sks-keyservers.net --recv-keys 0D2A45C3F1BAA57C</pre></li>
<li>Verify fingerprint:
<pre>sudo apt-key finger F1BAA57C
# compare output: Key fingerprint = FD9A 5764 17F7 B1D8 63C4 7A5A 0D2A 45C3 F1BA A57C</pre></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are commands to run, so the comment here looks a bit strange:
screenshot from 2017-04-04 11-11-33
I recommend adding that text below the command to run, since it's nothing to copy & paste. The key to compare can look different / monospaced.

martinpitt added a commit to martinpitt/cockpit-project.github.io that referenced this pull request Apr 4, 2017
The cockpit package has done this automatically for quite some time.

Closes cockpit-project#64
@martinpitt
Copy link
Member Author

Updated: http://piware.de/tmp/running.png

running.html Outdated
<pre>sudo apt-key adv --keyserver sks-keyservers.net --recv-keys 0D2A45C3F1BAA57C</pre></li>
<li>Verify fingerprint:
<pre>sudo apt-key finger F1BAA57C</pre>
<p>Compare the output: <span style="font-family: monospace">Key fingerprint = FD9A 5764 17F7 B1D8 63C4 7A5A 0D2A 45C3 F1BA A57C</span></p></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using the <tt> tag, like above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@dperpeet
Copy link
Contributor

dperpeet commented Apr 4, 2017

thanks!

@dperpeet dperpeet merged commit ca73a86 into cockpit-project:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants