[WIP] display image signature information #11
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any dummy data we can add the fixtures so we can see this on the test page in this project?
views/image-listing.html
Outdated
@@ -14,7 +15,7 @@ | |||
data-id="{{ imagestream.metadata.namespace + '/' + imagestream.metadata.name + ':' + tag.name }}" | |||
ng-class="{open: imagestreamExpanded(imagestream, tag), last: $last, first: $first}"> | |||
<tr ng-click="imagestreamActivate(imagestream, tag, $event)" class="listing-ct-item registry-listing"> | |||
<td ng-click="imagestreamToggle(imagestream, tag, $event)" class="listing-ct-toggle"> | |||
<td ng-click="imagestreamToggle(imagestream, tag, $event, imageByTag(tag))" class="listing-ct-toggle"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed?
views/image-listing.html
Outdated
@@ -61,6 +62,17 @@ | |||
</span> | |||
</div> | |||
</td> | |||
<td> | |||
<div class="row"> | |||
<span class="pficon pficon-ok" style="margin-right: 5px;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid styles like this and use classes instead.
images.js
Outdated
}; | ||
|
||
/* | ||
scope.imageSignatures = function imageSignatures(imagestream, tag) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to remove these commented out blocks
I think the |
Notes for usage
Create a private key and export the public key for use during signature verification.
Use the atomic command to push an image with the signature.
Note: Prior to atomic version 1.20.1, the --gnupghome option was not being honored. The workaround is to set GNUPGHOME.
Now view the image signatures with the oc command. Note the Status is Unverified.
Verify image signature using the oc adm command. A method to get the image reference is included for convenience.