Makefile: Don't clobber an existing bots checkout #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 95b2aff was a thinko -- for our CI we *don't* want our test to clobber a pre-existing bots/ checkout, as we often use this to run tests against an updated image or to validate a changes to the bots project. On developer machines, bots may also be a symlink to an actual bots directory in development, so don't clobber that.
|
The test log proves that it does not check out bots any more (make-checkout already did that). |
croissanne
approved these changes
Oct 1, 2019
This was referenced Oct 1, 2019
martinpitt
added a commit
to weldr/lorax
that referenced
this pull request
Oct 14, 2019
Commit 4643afa was a thinko -- for our CI we *don't* want our test to clobber a pre-existing bots/ checkout, as we often use this to run tests against an updated image or to validate a changes to the bots project. On developer machines, bots may also be a symlink to an actual bots directory in development, so don't clobber that. Stop making "bots" a phony target, and drop the now unnecessary `[ -d bots ]` check. Adapted from cockpit-project/starter-kit#232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 95b2aff was a thinko -- for our CI we don't want our test to
clobber a pre-existing bots/ checkout, as we often use this to run tests
against an updated image or to validate a changes to the bots project.
On developer machines, bots may also be a symlink to an actual bots
directory in development, so don't clobber that.