Move from webpack to esbuild bundler #636
Conversation
|
Thanks for looking into this!
The tests fail because this breaks translations. There's something wrong either with building dist/po.de.js, or with including it into the HTML page. Would you like to debug this yourself, for the learning exercise, and ask questions here or on Matrix, or would you like me to debug this myself? |
There was a problem hiding this comment.
@subhoghoshX po has to be loaded after index.js in order that it has the global cockpit object available. See cockpit-project/cockpit-podman@cbdd2a3
You can also remove the base1/cockpit.js include in the html file, as this is not external any more.
diff --git src/index.html src/index.html
index 3845f06..6eb0369 100644
--- src/index.html
+++ src/index.html
@@ -24,9 +24,8 @@ along with this package; If not, see <http://www.gnu.org/licenses/>.
<link rel="stylesheet" href="index.css">
- <script type="text/javascript" src="../base1/cockpit.js"></script>
- <script type="text/javascript" src="po.js"></script>
<script type="text/javascript" src="index.js"></script>
+ <script type="text/javascript" src="po.js"></script>
</head>
<body class="pf-m-redhat-font">
|
All TF tests passed! (except aarch64 ones). Thanks @KKoukiou :) |
|
Indeed this fails to build on non-x86_64 as there is no esbuild-wasm fallback. We have that in cockpit.git, but not yet in c-podman/machines (we still need to do that). |
Ah yes. That makes sense. May I give it a shot after this? |
|
@subhoghoshX : yes, of course! Let's add esbuild-wasm here (taking it from cockpit), and once it lands, please add it to these others. It doesn't block podman/machines as these don't rebuild the bundle during rpm build, but starter-kit and cockpit-certificates do. |
|
Yay, all tests PASSED! I figured I don't need to do any of the complicated things from Cockpit build.js as it has only one entry point 😄 |
|
@subhoghoshX Feel free to propose your improvements (build time, sourcemap, wasm) to cockpit-machines/podman, if you like. Cheers! |
Sync build.js with cockpit-podman and cockpit-machines.
Things I couldn't do and need assistance with:
COCKPIT_REPO_COMMIThash (https://github.com/cockpit-project/starter-kit/blob/main/Makefile#L37)Things I did differently:
sourcemapfromexternaltolinked. It fixes the issue of sourcemap not working. (https://esbuild.github.io/api/#sourcemap)notify-endesbuild plugin to also print the time it takes to finish building.