ActiveRecord base test fixes #62
Conversation
* CockroachDB uses unique_rowid() for primary keys, not sequences. It's
possible to force a table to use sequences, but since it's not the default
behavior we'll always return nil for default_sequence_name.
* The CockroachDB test schema replaces the PostgreSQL test schema used by the
ActiveRecord test suite. It's very similiar to the PostgreSQL schema, but
it removes anything that doesn't work against CockroachDB.
* Before loading the CockroachDB test schema, we first have to load the
ActiveRecord test helper. Besides loading dependencies that make the schema
load work, the AR test helper also loads the default schema used by all
databases.
* test/cases/helper_cockroachdb is loaded by every test file and it now loads
the AR test helper. Therefore, there's no need to explicitly load the AR
test helper in the test files.
We have to override extract_value_from_default so we can get the
correct time and date defaults for a couple of reasons.
1) There's a bug in CockroachDB where the date type is missing from the column
info query. cockroachdb/cockroach#47285
2) PostgreSQL's timestamp without time zone type maps to CockroachDB's
TIMESTAMP type. TIMESTAMP includes a UTC time zone while timestamp without
time zone doesn't. https://www.cockroachlabs.com/docs/v19.2/timestamp.html#variants
|
The Ruby segfault problem might be specific to the pg gem on macOS. Per ged/ruby-pg#311, I could get to the test to run and pass with h/t @marlabrizel for having seen this problem before 🌟 |
* The test fails because the setup doesn't account for other adapters like
CockroachDBAdapter.
|
Forgot to commit f110047 on Friday. |
| ); | ||
| _SQL | ||
|
|
||
| # Since stored procedures are not supported in CockroachDB, it won't be possible |
There was a problem hiding this comment.
Since this file is a copy of AR's PostgreSQL specific schema, I left stuff like this in place but commented out thinking it might make it easier to see the differences between the two files. We can take it out if it isn't helpful. What do you think?
|
Looks good, just making sure the branch is in the state you want. |
|
It's ready to merge. |
* In addition to handling dates and times, extract_value_from_default also
needs to handle escaped strings.
* Both PostgreSQL and CockroachDB use C-style string escapes under the covers.
PostgreSQL obscures this for us and unescapes the strings, but CockroachDB
does not. extract_value_from_default can unescape the strings via Ruby.
* The PostgresqlDefaultExpressionTest tests fail because CockroachDB uses
different functions than PostgreSQL for current date/timestamps.
* The test has been replaced by CockroachDB::DefaultExpressionTest, and it
uses CockroachDB's current_date() and current_timestamp() functions in its
assertions.
|
I added a couple more changes to fix things I came across in 7ad6f53 updates 98bf1a8 replaces an AR test to work with CockroachDB's |
This includes a few changes to fix ActiveRecord's base test.
The biggest change is the introduction of a CockroachDB specific test schema. It's a copy of the PostgreSQL test schema defined by ActiveRecord with a few changes so it works for CockroachDB.
See the commits for more details on the changes.
Note: there's an outstanding failure in the base test.
test_marshal_between_processescauses a Ruby segfault when it tries to open a new connection in a forked process. I'm not sure what's going there so I'm tabling it for now.