Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return number of zeros removed during reduce #46

Merged
merged 1 commit into from
Mar 30, 2017
Merged

return number of zeros removed during reduce #46

merged 1 commit into from
Mar 30, 2017

Conversation

maddyblue
Copy link
Contributor

@maddyblue maddyblue commented Mar 29, 2017 •
edited
Loading

This is useful to determine if any zero truncation occurred without running a CmpTotal.

This change is Reviewable

@eisenstatdavid
Copy link
Contributor

:lgtm:

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@maddyblue
Copy link
Contributor Author

Added some tests to make sure all code paths are tested.

@eisenstatdavid
Copy link
Contributor

:lgtm:

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@maddyblue maddyblue merged commit 9d633bb into master Mar 30, 2017
@maddyblue maddyblue deleted the reduce-num branch March 30, 2017 19:05
@maddyblue maddyblue mentioned this pull request Apr 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eisenstatdavid eisenstatdavid Awaiting requested review from eisenstatdavid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddyblue @eisenstatdavid