Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer #47

Merged
merged 3 commits into from
Mar 30, 2017
Merged

Integer #47

merged 3 commits into from
Mar 30, 2017

Conversation

maddyblue
Copy link
Contributor

@maddyblue maddyblue commented Mar 30, 2017

This change is Reviewable

@nvanbenschoten
Copy link
Member

:lgtm: Thanks for the example!


Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


example_test.go, line 119 at r1 (raw file):

	for _, input := range inputs {
		d, _, _ := apd.NewFromString(input)
		res, _ := apd.BaseContext.ToIntegralX(d, d)

Just curious, why is it called ToIntegralX?


Comments from Reviewable

@maddyblue
Copy link
Contributor Author

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


example_test.go, line 119 at r1 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

Just curious, why is it called ToIntegralX?

That's what the test directive is called. But I've opened #48 to improve the names because they're not clear.


Comments from Reviewable

@maddyblue maddyblue merged commit 3d2c361 into master Mar 30, 2017
@maddyblue maddyblue deleted the integer branch March 30, 2017 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants