Enable assertions in race builds #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
We need to revert 0cc8a3d first, right? |
|
LGTM |
|
The parent of this commit is 4.8, so we don't need to revert. We can point the glockfile to this commit (pre-merge) for assertions-enabled 4.8, and the merge of this commit for assertions-enabled 4.9. |
|
Neat. On Sep 8, 2016 00:44, "Ben Darnell" notifications@github.com wrote:
|
benesch
added a commit
to benesch/cockroach
that referenced
this pull request
May 16, 2017
In the transition to the new Make-based build system for C dependencies (4d72e12), RocksDB assertions were inadvertently enabled for all builds. Restore the old behavior, which only enabled assertions for race builds (cockroachdb/c-rocksdb#27). Fixes cockroachdb#15604.
benesch
added a commit
to benesch/cockroach
that referenced
this pull request
May 16, 2017
In the transition to the new Make-based build system for C dependencies (4d72e12), RocksDB assertions were inadvertently enabled for all builds. Restore the old behavior, which only enabled assertions for race builds (cockroachdb/c-rocksdb#27). Fixes cockroachdb#15604.
mberhault
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
May 16, 2017
In the transition to the new Make-based build system for C dependencies (4d72e12), RocksDB assertions were inadvertently enabled for all builds. Restore the old behavior, which only enabled assertions for race builds (cockroachdb/c-rocksdb#27). Fixes #15604.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cockroachdb/cockroach#9168
@cockroachdb/stability