Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdrb tx: remove libpq specific error #136

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

drakkan
Copy link
Contributor

@drakkan drakkan commented May 17, 2022

libpq implements SQLState() string method as pgx since 1.10.6.

I think we could also replace the remaining lib/pq imports with pgx in the future. Fow now is better to keep them and require lib/pq 1.10.6

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@drakkan
Copy link
Contributor Author

drakkan commented May 17, 2022

This patch must be merged after #132 I just applied the changes there to verify that tests pass. I'll now revert that changes using a force-push

Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, will this break anything for users who do not upgrade to the new version of lib/pq?

i wonder if we'd need a new major release if so

@drakkan
Copy link
Contributor Author

drakkan commented May 18, 2022

hm, will this break anything for users who do not upgrade to the new version of lib/pq?

i wonder if we'd need a new major release if so

lib/pq is still imported here and in the testserver, so it is still in the go.mod.

I bumped the version in go.mod to 1.10.6, so this should not be a breaking change.
In the future we should replace these imports with pgx and so lib/pq will be removed from go.mod and this will be a breaking change suitable for a major version

libpq implements SQLState() string method as pgx since 1.10.6
@rafiss
Copy link
Contributor

rafiss commented May 19, 2022

i see. thanks for your contribution!

@rafiss rafiss merged commit c6f8429 into cockroachdb:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants