Allow passing in environment variables to the start command

[rafiss]

No description provided.

[cockroach-teamcity]

This change is 

[pawalt]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

testserver/testservernode.go line 51 at r1 (raw file):

		"COCKROACH_TRUST_CLIENT_PROVIDED_SQL_REMOTE_ADDR=true",
		"COCKROACH_FORCE_DEV_VERSION=true",
		"COCKROACH_UPGRADE_TO_DEV_VERSION=true",

I'm sure I'm missing context here, but why do we always add the environment variables? Won't this force an upgrade even if the user doesn't want an upgrade to a dev version?

---

testserver/testservernode.go line 62 at r1 (raw file):

		wr, err := newFileLogWriter(fmt.Sprintf("%s.%d", ts.stdout, i))
		if err != nil {
			return fmt.Errorf("unable to open file %s: %w", ts.stdout, err)

Can you update this error message to reflect the new filename

---

testserver/testservernode.go line 71 at r1 (raw file):

		wr, err := newFileLogWriter(fmt.Sprintf("%s.%d", ts.stderr, i))
		if err != nil {
			return fmt.Errorf("unable to open file %s: %w", ts.stderr, err)

ditto

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @pawalt)

---

testserver/testservernode.go line 51 at r1 (raw file):

Previously, pawalt (Peyton Walters) wrote…

I'm sure I'm missing context here, but why do we always add the environment variables? Won't this force an upgrade even if the user doesn't want an upgrade to a dev version?

no prob - these env vars are new and also not too intuitive. essentially, the behavior is:

• one allows you to upgrade from an official version to a dev version clusterversion: require env var to do poison dev upgrades cockroach#87468
• one allows you to upgrade from a dev version to an official version clusterversion: allow forcing release binary to dev version cockroach#90002

so they're just about what's allowed -- it doesn't actually force any upgrades

it's probably better for me to make a more general way of passing in env vars though. i'll do that instead.

---

testserver/testservernode.go line 62 at r1 (raw file):

Previously, pawalt (Peyton Walters) wrote…

Can you update this error message to reflect the new filename

i got rid of this change since it's unrelated to this PR and doesn't actually help with what i was trying to get it to do

---

testserver/testservernode.go line 71 at r1 (raw file):

Previously, pawalt (Peyton Walters) wrote…

ditto

same

[pawalt]

Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained

[pawalt]

[rafiss]

thanks!