Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment has private image in it #34

Closed
chrislovecnm opened this issue Jul 6, 2020 · 6 comments
Closed

Deployment has private image in it #34

chrislovecnm opened this issue Jul 6, 2020 · 6 comments

Comments

@chrislovecnm
Copy link
Contributor

Do not have the current container image https://github.com/cockroachdb/cockroach-operator/blob/master/deploy/operator.yaml#L181

This does not allow for external use.

@chrislovecnm
Copy link
Contributor Author

chrislovecnm commented Jul 6, 2020

@JuanLeon1

@chrislovecnm chrislovecnm changed the title Deployment has bug in it Deployment has private image in it Jul 6, 2020
@chrislovecnm
Copy link
Contributor Author

I will implement moving to kustomize to build the yaml file, that way we can easily overlay the yaml file for testing, but have the stable yaml file checked in

@chrislovecnm
Copy link
Contributor Author

curl -s "https://raw.githubusercontent.com/\
kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"  | bash

@chrislovecnm
Copy link
Contributor Author

I'm fixing this with kustomize, but I still do not like the implementation. I think I need to create a kustomize file dynamically.

@johnrk-zz johnrk-zz added this to To do in Kubernetes Operator via automation Jul 10, 2020
@chrislovecnm
Copy link
Contributor Author

I fixed this in #38

But we need to document it and probably improve how we are doing this. We are creating a new file that git wants to check-in, instead of using a temp file.

Eventually, I want the actual version of the container in this file, which will be modified when we push releases

@chrislovecnm
Copy link
Contributor Author

Closing and opening a couple of issues

Kubernetes Operator automation moved this from To do to Done Jul 11, 2020
@johnrk-zz johnrk-zz removed this from Done in Kubernetes Operator Jul 14, 2020
@johnrk-zz johnrk-zz added this to To do in Cockroach Kubernetes Operator via automation Jul 14, 2020
@johnrk-zz johnrk-zz moved this from To do to Done in Cockroach Kubernetes Operator Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant