-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment has private image in it #34
Comments
I will implement moving to kustomize to build the yaml file, that way we can easily overlay the yaml file for testing, but have the stable yaml file checked in |
|
I'm fixing this with kustomize, but I still do not like the implementation. I think I need to create a kustomize file dynamically. |
I fixed this in #38 But we need to document it and probably improve how we are doing this. We are creating a new file that git wants to check-in, instead of using a temp file. Eventually, I want the actual version of the container in this file, which will be modified when we push releases |
Closing and opening a couple of issues |
Do not have the current container image https://github.com/cockroachdb/cockroach-operator/blob/master/deploy/operator.yaml#L181
This does not allow for external use.
The text was updated successfully, but these errors were encountered: