Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting to create a GKE Cluster and install operator #38

Merged
merged 10 commits into from
Jul 9, 2020

Conversation

chrislovecnm
Copy link
Contributor

@chrislovecnm chrislovecnm commented Jul 7, 2020

This PR includes some shell scripts that allow for

  • the creation of a GKE cluster
  • build and push the operator container into gcr
  • install the operator
  • install a basic example
  • other scripts that allow you to cleanup

@chrislovecnm
Copy link
Contributor Author

cc @chrisseto @johnrk

@chrislovecnm chrislovecnm changed the title Scripting to create a GKE cluster WIP - Scripting to create a GKE cluster Jul 7, 2020
@chrislovecnm chrislovecnm marked this pull request as draft July 7, 2020 18:23
@chrislovecnm chrislovecnm changed the title WIP - Scripting to create a GKE cluster WIP - Scripting to create a GKE Cluster Jul 7, 2020
@chrislovecnm
Copy link
Contributor Author

@johnrk this is blocked by lack of GCP account

This PR includes some shell scripts that allow for the creation of an GKE cluster
and pushing the operator container to GCP.
This work will eventually create and install the operators, but I am doing the work
in sections.
Now able to get a basic cluster working, but still have some cleanup to work on.
- Added functionity to look up the latest image
- Fixed README.md
@chrislovecnm chrislovecnm changed the title WIP - Scripting to create a GKE Cluster Scripting to create a GKE Cluster and install operator Jul 8, 2020
@chrislovecnm chrislovecnm marked this pull request as ready for review July 8, 2020 20:34
@chrislovecnm
Copy link
Contributor Author

cc @chrisseto PTAL

- because we are doing a cd to get kustomize to work, we
are ending up in the wrong directory unless you run it from the
root git directory.  This change fixes that.
- we probably should create a dynamic kustomize files so that
we are not checking in new ones
The node field nodeTLSSecret is stopping the creation of
the certificates and then the secret does not exist, and the
cluster does not start. I'm figuring out what exactly this feild
is for, and I think it might be for custom cert creation.

Will test the examples more, but I think that they are working now
All of them are running now
We need a bigger cluster to run all of the examples at the same time
Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


# "---------------------------------------------------------"
# "- -"
# "- deploy the operator -"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking to see if it is fix. I think it is a tab vs spaces problem.


# "---------------------------------------------------------"
# "- -"
# "- deploy the operator -"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking to see if it is fix. I think it is a tab vs spaces problem.

@@ -11,7 +11,8 @@ spec:
resources:
requests:
storage: 60Gi
storageClassName: crdb-io1
# this needs to be precreated and we are not checking this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this block be removed?

@chrislovecnm
Copy link
Contributor Author

@chrisseto I fixed the comments. Can we merge?

@chrisseto chrisseto merged commit 0bcd704 into cockroachdb:master Jul 9, 2020
This was referenced Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants