sql/stmtdiagnostics: TestDiagnosticsRequest failed

[cockroach-teamcity]

sql/stmtdiagnostics.TestDiagnosticsRequest failed with artifacts on release-23.1 @ b4533bdbc4b478f0ad311bad80b62bd072cf61cf:

=== RUN   TestDiagnosticsRequest
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/cb4e70d2cc4a901d2a7689654ffd0100/logTestDiagnosticsRequest1603224081
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestDiagnosticsRequest
    statement_diagnostics_test.go:62: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:62
        	            				github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:82
        	            				github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:327
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:71
        	            				github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:77
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:59
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:41
        	            				github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:296
        	Error:      	Should be false
        	Test:       	TestDiagnosticsRequest
        	Messages:   	request was completed and should have been removed from the registry
=== CONT  TestDiagnosticsRequest
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/cb4e70d2cc4a901d2a7689654ffd0100/logTestDiagnosticsRequest1603224081
--- FAIL: TestDiagnosticsRequest (10.90s)
=== RUN   TestDiagnosticsRequest/ongoing_request_canceled/conditional
=== CONT  TestDiagnosticsRequest/ongoing_request_canceled/conditional
    testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
        --- FAIL: TestDiagnosticsRequest/ongoing_request_canceled/conditional (0.43s)
=== RUN   TestDiagnosticsRequest/ongoing_request_canceled
=== CONT  TestDiagnosticsRequest/ongoing_request_canceled
    testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
    --- FAIL: TestDiagnosticsRequest/ongoing_request_canceled (0.43s)

Parameters: TAGS=bazel,gss,deadlock

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-27904

[cockroach-teamcity]

sql/stmtdiagnostics.TestDiagnosticsRequest failed with artifacts on release-23.1 @ 6804aba73aecf63e0bfc7b648b9883d0286f7173:

=== RUN   TestDiagnosticsRequest
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/cb4e70d2cc4a901d2a7689654ffd0100/logTestDiagnosticsRequest4189300529
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestDiagnosticsRequest
    statement_diagnostics_test.go:62: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:62
        	            				github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:82
        	            				github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:327
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:71
        	            				github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:77
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:59
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:41
        	            				github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics_test/pkg/sql/stmtdiagnostics/statement_diagnostics_test.go:296
        	Error:      	Should be false
        	Test:       	TestDiagnosticsRequest
        	Messages:   	request was completed and should have been removed from the registry
=== CONT  TestDiagnosticsRequest
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/cb4e70d2cc4a901d2a7689654ffd0100/logTestDiagnosticsRequest4189300529
--- FAIL: TestDiagnosticsRequest (10.89s)
=== RUN   TestDiagnosticsRequest/ongoing_request_canceled
=== CONT  TestDiagnosticsRequest/ongoing_request_canceled
    testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
    --- FAIL: TestDiagnosticsRequest/ongoing_request_canceled (0.48s)
=== RUN   TestDiagnosticsRequest/ongoing_request_canceled/conditional
=== CONT  TestDiagnosticsRequest/ongoing_request_canceled/conditional
    testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
        --- FAIL: TestDiagnosticsRequest/ongoing_request_canceled/conditional (0.48s)

Parameters: TAGS=bazel,gss,deadlock

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

[msirek]

Unable to reproduce this with:

bazel test //pkg/sql/stmtdiagnostics:stmtdiagnostics_test --test_env=COCKROACH_NIGHTLY_STRESS=true --test_env=GOTRACEBACK=all --test_timeout=3660 --test_arg=-test.timeout=3655s --run_under '@com_github_cockroachdb_stress//:stress -bazel -maxruns 100 -maxtime 1h0m0s -maxfails 1 -p 4' --define gotags=bazel,gss,deadlock --nocache_test_results --test_output streamed --test_sharding_strategy=disabled --jobs 4  --build_event_binary_file=/tmp/beplog

[msirek]

Closing
Unable to reproduce this failure, and this is the first time this specific flavor of this test failure has occurred.
If it recurs maybe someone can think of a creative way to reproduce it.