Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: costfuzz/seed-multi-region failed #106507

Closed
cockroach-teamcity opened this issue Jul 10, 2023 · 2 comments
Closed

roachtest: costfuzz/seed-multi-region failed #106507

cockroach-teamcity opened this issue Jul 10, 2023 · 2 comments
Labels
branch-master Failures on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 10, 2023

roachtest.costfuzz/seed-multi-region failed with artifacts on master @ 0207c613fa7c8f3ab66c4518ee1e52dabb863426:

  	"1969-09-23 00:08:20 +0000 UTC,19,19,0",
  	... // 25 identical elements
  	"1969-09-23 00:08:20 +0000 UTC,19,19,0",
  	"1969-09-23 00:08:20 +0000 UTC,19,19,NULL",
+ 	"1969-09-23 00:08:20 +0000 UTC,19,19,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,19,19,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,19,19,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,19,19,NaN",
- 	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,0",
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,0",
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,0",
  	... // 25 identical elements
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,0",
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,NULL",
+ 	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,1940934034,1940934034,NaN",
- 	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,0",
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,0",
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,0",
  	... // 25 identical elements
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,0",
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,NULL",
+ 	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,NaN",
  	"1969-09-23 00:08:20 +0000 UTC,381128847,381128847,NaN",
- 	"1969-09-23 00:08:20 +0000 UTC,NULL,NULL,0",
  	"1969-09-23 00:08:20 +0000 UTC,NULL,NULL,0",
  	"1969-09-23 00:08:20 +0000 UTC,NULL,NULL,0",
  	... // 30 identical elements
  	"1969-09-23 00:08:20 +0000 UTC,NULL,NULL,NULL",
  	"1969-09-23 00:08:20 +0000 UTC,NULL,NULL,NULL",
+ 	"1969-09-23 00:08:20 +0000 UTC,NULL,NULL,NaN",
  	... // 204 identical elements
  }
sql: SELECT
	"ta%adb564"._timestamptz AS col1926,
	tab563._int4 AS "co l\\uB3491927",
	tab563._int4 AS col1928,
	var_pop("ta%adb564"._float8::FLOAT8)::FLOAT8 AS col1929
FROM
	defaultdb.public.seed_mr_table@[0] AS tab563
	JOIN defaultdb.public.seed_mr_table@[0] AS "ta%adb564" ON (tab563._bool) = ("ta%adb564"._bool)
WHERE
	(("ta%adb564"._string NOT ILIKE tab563._string) OR true)
GROUP BY
	"ta%adb564"._timestamptz, "ta%adb564"._int4, tab563._int4, "ta%adb564"._float8
test artifacts and logs in: /artifacts/costfuzz/seed-multi-region/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-29594

@cockroach-teamcity cockroach-teamcity added branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Jul 10, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Jul 10, 2023
@cockroach-teamcity cockroach-teamcity added this to Triage in SQL Queries Jul 10, 2023
@DrewKimball
Copy link
Collaborator

Looks related to #102676. #105694 was included in this commit, so it looks like the increased accuracy for intermediate results wasn't enough to solve these 0 -> NaN problems. I think this might be solved by rounding the intermediate result to zero if it's less than zero, so that the sqrt calculation doesn't return NaN.

@msirek
Copy link
Contributor

msirek commented Jul 11, 2023

dupe of #102676

@msirek msirek closed this as completed Jul 11, 2023
SQL Queries automation moved this from Triage to Done Jul 11, 2023
@srosenberg srosenberg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 11, 2023
@michae2 michae2 added the O-rsg Random Syntax Generator label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

No branches or pull requests

5 participants