Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/start: improper graceful drain upon stop trigger shutdown requests #108611

Closed
knz opened this issue Aug 11, 2023 · 0 comments · Fixed by #108612
Closed

cli/start: improper graceful drain upon stop trigger shutdown requests #108611

knz opened this issue Aug 11, 2023 · 0 comments · Fixed by #108612
Labels
A-cli-server CLI commands that pertain to CockroachDB server processes A-server-start-drain Pertains to server startup and shutdown sequences C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. db-cy-23

Comments

@knz
Copy link
Contributor

knz commented Aug 11, 2023 •
edited by cockroach-jira-scripts

Describe the problem

The shutdown logic in cli/start tries graceful drains when receiving shutdown requests. This is incorrect; currently all shutdown reasons require non-graceful shutdowns.

Expected behavior

For all the current reasons the code in cli/start should use a non-graceful shutdown.

Epic: CRDB-28893

Jira issue: CRDB-30548
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cli-server CLI commands that pertain to CockroachDB server processes A-server-start-drain Pertains to server startup and shutdown sequences labels Aug 11, 2023
@knz knz mentioned this issue Aug 11, 2023
Merged
@knz knz added the db-cy-23 label Aug 11, 2023
@craig craig bot closed this as completed in f32fc17 Aug 11, 2023
@knz knz mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli-server CLI commands that pertain to CockroachDB server processes A-server-start-drain Pertains to server startup and shutdown sequences C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. db-cy-23
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli,server: distinguish graceful vs non-graceful shutdown requests knz/cockroach
1 participant
@knz