Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: type check target pulls 178MB off a 3rd party vendor upon every CI run, and fails if upstream is unavailable #109154

Closed
knz opened this issue Aug 21, 2023 · 1 comment
Labels
A-build-system branch-master Failures on the master branch. branch-release-23.1 Used to mark GA and release blockers and technical advisories for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. S-3-productivity Severe issues that impede the productivity of CockroachDB developers. T-dev-inf

Comments

@knz
Copy link
Contributor

knz commented Aug 21, 2023

This is a variant of #51543 and is currently causing flakes in CI.

Describe the problem

The pkg/ui/workspaces/e2e-tests target downloads the following URL every time it runs:

https://download.cypress.io/desktop/10.3.0?platform=linux&arch=x64

I went and checked and that is a 178MB archive to download (compressed).

The archive is not cached, unlike the builder image, so that's a mandatory ingress cost on every CI run.

Moreover, today the upstream HTTP server is saying "no" and is causing all the CI runs to fails. (example)
image

Expected behavior

The archive should be embedded in the builder image, and/or the fetch should use a cached copy if it was already downloaded earlier on the TC agent.

(At the very least we should be fetching from a proxy cache inside the CRL infra so that the CI downloads are internal to GCP).

cc @sjbarag @jlinder @rickystewart for triage.

Epic DEVINF-109

Jira issue: CRDB-30805

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). S-3-productivity Severe issues that impede the productivity of CockroachDB developers. A-build-system branch-master Failures on the master branch. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-dev-inf branch-release-23.1 Used to mark GA and release blockers and technical advisories for 23.1 labels Aug 21, 2023
@rickystewart
Copy link
Collaborator

For CI, this should be fixed by #109157. Please re-open if the problem seems to recur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system branch-master Failures on the master branch. branch-release-23.1 Used to mark GA and release blockers and technical advisories for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. S-3-productivity Severe issues that impede the productivity of CockroachDB developers. T-dev-inf
Projects
None yet
Development

No branches or pull requests

2 participants