Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: gate all statement bundle operations under VIEWACTIVITY #121301

Open
xinhaoz opened this issue Mar 28, 2024 · 0 comments
Open

ui: gate all statement bundle operations under VIEWACTIVITY #121301

xinhaoz opened this issue Mar 28, 2024 · 0 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability

Comments

@xinhaoz
Copy link
Member

xinhaoz commented Mar 28, 2024

Currently, requesting, viewing (downloading), and deleting statement bundle requests from DB console are all gated under different permissions:

All of the above operations should be allowed with VIEWACTIVITY. One option is to create a VIEWACTIVITY gated view on top of the statement bundle table and an equivalent builtin to perform deletes. The alternative is to revert to using the grpc endpoints for statement bundles (this is likely preferred over creating new views and builtins).

This is technically a regression - prior to 23.1 we used the GRPC endpoint to perform stmt bundle operations from db-console, which only required VIEWACTIVITY. For 23.1+ we switched to use sql-over-http, which used incorrectly gated sql queries/functions (referenced above).

Jira issue: CRDB-37176

@xinhaoz xinhaoz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. and removed C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability
Projects
None yet
Development

No branches or pull requests

1 participant