Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: don't apply disallow_full_table_scans to virtual tables #122708

Closed
DrewKimball opened this issue Apr 19, 2024 · 0 comments · Fixed by #123780
Closed

sql: don't apply disallow_full_table_scans to virtual tables #122708

DrewKimball opened this issue Apr 19, 2024 · 0 comments · Fixed by #123780
Assignees
@yuzefovich
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months T-sql-queries SQL Queries Team

Comments

@DrewKimball
Copy link
Collaborator

DrewKimball commented Apr 19, 2024 •
edited by cockroach-jira-scripts
Loading

Since we currently don't collect stats for virtual tables, (tracked in #27611), we unconditionally apply costing changes due to the disallow_full_table_scans setting for virtual table scans, even if large_full_scan_rows is larger than the row count. Until tracked in #27611 is fixed, we should prevent disallow_full_table_scans from applying to virtual tables, likely using a setting.

Jira issue: CRDB-38031
@DrewKimball DrewKimball added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-sql-queries SQL Queries Team labels Apr 19, 2024
@rytaft rytaft added the P-2 Issues/test failures with a fix SLA of 3 months label May 6, 2024
@yuzefovich yuzefovich self-assigned this May 7, 2024
@yuzefovich yuzefovich mentioned this issue May 7, 2024
Merged
@craig craig bot closed this as completed in e0951b9 May 9, 2024
This was referenced May 9, 2024
Merged
Merged
@yuzefovich yuzefovich mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

opt: don't apply huge cost for full scans of virtual tables yuzefovich/cockroach
3 participants
@rytaft @yuzefovich @DrewKimball