Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replicastats: avoid unnecessary indirection on replicaStatsRecord.localityCounts #123271

Open
nvanbenschoten opened this issue Apr 30, 2024 · 0 comments
Open

replicastats: avoid unnecessary indirection on replicaStatsRecord.localityCounts #123271

nvanbenschoten opened this issue Apr 30, 2024 · 0 comments
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. E-quick-win Likely to be a quick win for someone experienced. T-kv KV Team
Projects
KV

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Apr 30, 2024 •
edited by cockroach-jira-scripts

In the spirit of the memory improvements made in #123167, we should change replicaStatsRecord.localityCounts to store a reference to PerLocalityCounts (a map header), instead of a pointer to PerLocalityCounts.

See the discussion in #93823 (comment).

Jira issue: CRDB-38265
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. A-kv-distribution Relating to rebalancing and leasing. T-kv KV Team E-quick-win Likely to be a quick win for someone experienced. labels Apr 30, 2024
@blathers-crl blathers-crl bot added this to Incoming in KV Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. E-quick-win Likely to be a quick win for someone experienced. T-kv KV Team
Projects
KV
Incoming
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvanbenschoten