Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: improve test coverage of initial scans #123699

Closed
7 tasks
rharding6373 opened this issue May 6, 2024 · 2 comments
Closed
7 tasks

changefeedccl: improve test coverage of initial scans #123699

rharding6373 opened this issue May 6, 2024 · 2 comments
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented May 6, 2024

The initial scan and checkpointing code is brittle. We should improve quality in this area by:

  • Add a randomized test that creates a random table, does an initial scan, then compares the output to the original table.
  • Add changefeeds with initial scans to the cdc roachtest chaos testing.
  • Add test-only assertions for the timestamp 0 invariant during initial scans.

Other tests/validation outside of initial scans that would also improve quality:

  • Add a randomized test that creates a random table, does random inserts/updates/deletes, then compares the output to the original table (could be paired with initial scan).
  • Ensure that ordering and at least once delivery validators are added to all CDC roachtests
  • Add ordering and at least once delivery validation to DRT cluster sinks.
  • Add changefeeds to all tests at random and validate correctness (similar to DR's backup/restore after tests)

Jira issue: CRDB-38488

@rharding6373 rharding6373 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels May 6, 2024
Copy link

blathers-crl bot commented May 6, 2024

cc @cockroachdb/cdc

@rharding6373 rharding6373 added O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months labels May 6, 2024
@rharding6373
Copy link
Collaborator Author

Closing in favor of this epic, which tracks these and other test improvements as separate issues: https://cockroachlabs.atlassian.net/browse/CRDB-38755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months T-cdc
Projects
None yet
Development

No branches or pull requests

1 participant