Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg_catalog: fix up pg_catalog.pg_attribute #123706

Open
yuzefovich opened this issue May 7, 2024 · 0 comments
Open

pg_catalog: fix up pg_catalog.pg_attribute #123706

yuzefovich opened this issue May 7, 2024 · 0 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. O-pg-regress Originated from the pg_regress test suite. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@yuzefovich
Copy link
Member

yuzefovich commented May 7, 2024

In postgres, the following query returns 0 rows:

-- Cross-check attnum against parent relation

SELECT a1.attrelid, a1.attname, c1.oid, c1.relname
FROM pg_attribute AS a1, pg_class AS c1
WHERE a1.attrelid = c1.oid AND a1.attnum > c1.relnatts;

while we receive a few hundred. We should fix it up (and adjust pg_regress roachtest accordingly).

Jira issue: CRDB-38492

@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-sql-pgcompat Semantic compatibility with PostgreSQL T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) O-pg-regress Originated from the pg_regress test suite. labels May 7, 2024
@blathers-crl blathers-crl bot added this to Triage in SQL Foundations May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. O-pg-regress Originated from the pg_regress test suite. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
  
Triage
Development

No branches or pull requests

1 participant