Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: warn or error when user specifies resolved < min_checkpoint_frequency #125884

Open
andyyang890 opened this issue Jun 18, 2024 · 1 comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@andyyang890
Copy link
Collaborator

andyyang890 commented Jun 18, 2024

We already have a strongly-worded note in our public docs saying that the user should take care to make sure that min_checkpoint_frequency <= resolved since we won't emit resolved timestamps more frequently than min_checkpoint_frequency. We should either enforce this condition in code or at least issue a warning if the user violates this.

One argument against making this an error would be that it could be a breaking change for existing changefeeds.

Jira issue: CRDB-39646

@andyyang890 andyyang890 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Jun 18, 2024
Copy link

blathers-crl bot commented Jun 18, 2024

cc @cockroachdb/cdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Development

No branches or pull requests

1 participant