Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add support for HAVING #2175

Closed
petermattis opened this issue Aug 20, 2015 · 2 comments
Closed

sql: add support for HAVING #2175

petermattis opened this issue Aug 20, 2015 · 2 comments
Assignees
@dt
Milestone
1.0

Comments

@petermattis
Copy link
Collaborator

HAVING clauses are like WHERE clauses but are evaluated after GROUP BY while WHERE clauses are evaluated on the rows from a table. Once GROUP BY is implemented (see #2174), support for HAVING should be straightforward.
@petermattis petermattis added this to the 1.0 milestone Aug 20, 2015
@jess-edwards jess-edwards mentioned this issue Aug 20, 2015
Closed
78 tasks
@petermattis
Copy link
Collaborator Author

While this is currently earmarked for 1.0, the implementation should be straightforward once #2201 lands and we have a groupNode. We just need to evaluate the HAVING clause for correctness and then use it to filter the output of a groupNode similar to the WHERE clause filters the output of a scanNode.

@dt
Copy link
Member

dt commented Dec 30, 2015

Fixed in #3547

@dt dt closed this as completed Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dt dt

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@dt @petermattis