Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostics: include settings names in scrubbed query stats #22723

Closed
dt opened this issue Feb 15, 2018 · 0 comments
Closed

diagnostics: include settings names in scrubbed query stats #22723

dt opened this issue Feb 15, 2018 · 0 comments
Assignees

Comments

@dt
Copy link
Member

dt commented Feb 15, 2018

Concretely, currently we might report that this ran twice:

SET CLUSTER SETTING _ = _

Instead, since the settings names are hard-coded consts, we know they're non-sentiive and we can instead report that that each of these ran once:

SET CLUSTER SETTING kv.bulk_sst.sync_size = _
SET CLUSTER SETTING kv.bulk_io_write.max_rate = _

We currently scrub settings names from diagnostics collection because we just scrub all strings from the query AST, but settings names are actually taken from a relatively small set of known const strings and we an check they're valid with settings.Lookup, in which case they can be left unscrubbed, providing extra insight into what settings users need to change and how often.

This product question is already partially answered by including the set of non-default settings in diagnostics reporting -- we can already see what settings users have set and can even see that set change between report -- but if e.g. a setting was changed 20 times between reports, we'd only see the fact that it was different at the next report, not that it took several attempt to tune it or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants