Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: PGAdmin Testing Investigation #26603

Open
BramGruneir opened this issue Jun 11, 2018 · 5 comments
Open

sql: PGAdmin Testing Investigation #26603

BramGruneir opened this issue Jun 11, 2018 · 5 comments
Labels
C-investigation Further steps needed to qualify. C-label will change. meta-issue Contains a list of several other issues. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@BramGruneir
Copy link
Member

BramGruneir commented Jun 11, 2018

While testing out PGAdmin's test suite, the following issues cause test failures. Note that this is not a list of extensions to implement but a list of what fell out of my investigation into PGAdmin. We will not support a good number of these.

So we should be able to create a subset of tests that we will support (and run) and what we won't.

The most important item to unlock testing is the correct full handling of schemas.

Feature Issue # Achievable Other demand known Planned PostgreSQL docs
CREATE USER WITH NOLOGIN yes (S) yes link
CREATE ROLE username LOGIN yes (S) yes link
CREATE DATABASE WITH OWNER yes (S) link
CREATE SCHEMA #26443 yes (M) yes probably link
COMMENT ON DATABASE #26617 yes (M) yes link
CREATE CAST yes (L) link
CREATE COLLATION yes (L) link
CREATE DOMAIN yes (L) link
(fts) CREATE TEXT SEARCH CONFIGURATION yes (XL) yes link
(fts) CREATE TEXT SEARCH DICTIONARY yes (XL) yes link
(fts) CREATE TEXT SEARCH TEMPLATE yes (XL) yes link
(fts) DROP TEXT SEARCH PARSER yes (XL) yes link
(procedures, not stored) DO $$ yes (XXL) yes (stored procs) yes link
row_to_json #37124 Yes link
pg_catalog.pg_default_acl #26378 Yes link
CREATE EVENT TRIGGER perhaps (XL) yes link
CREATE EXTENSION prob.no (XXL) link
CREATE TRUSTED PROCEDURAL LANGUAGE prob.no (XXL) link
(fdw) CREATE FOREIGN DATA WRAPPER no link
(fdw) CREATE FOREIGN TABLE no link
(fdw) CREATE SERVER no link
(fdw) CREATE USER MAPPING FOR no link
pg_terminate_backend() no link

Jira issue: CRDB-4995

@BramGruneir
Copy link
Member Author

@awoods187 Can you look through this list and augment it with what's on our roadmap and what's not?

@knz
Copy link
Contributor

knz commented Jun 12, 2018

I have created a table above with the detail of the features. I think most of them we will not implement anytime soon. It would be better for now to simply skip these tests.

@knz knz added the C-investigation Further steps needed to qualify. C-label will change. label Jun 12, 2018
@knz knz moved this from Triage to Current milestone in (DEPRECATED) SQL Front-end, Lang & Semantics Jun 12, 2018
@knz knz added the meta-issue Contains a list of several other issues. label Jun 12, 2018
@knz knz moved this from Current milestone to ORM/Tool Compat Meta-issues in (DEPRECATED) SQL Front-end, Lang & Semantics Jun 14, 2018
@knz knz changed the title PGAdmin Testing Investigation sql: PGAdmin Testing Investigation Jul 23, 2018
@knz knz moved this from ORM/Tool Compat Meta-issues to Feature requests / pie-in-the-skie in (DEPRECATED) SQL Front-end, Lang & Semantics Oct 23, 2018
@jordanlewis jordanlewis moved this from Triage to ORM and tool tracking in [DEPRECATED] Old SQLExec board. Don't move stuff here May 7, 2019
@awoods187 awoods187 added this to Backlog in SQL Sessions - Deprecated via automation Mar 25, 2020
@vy-ton
Copy link
Contributor

vy-ton commented Nov 30, 2020

@rafiss I don't believe PGAdmin's test suite is integrated into our CI but it could be one to prioritized. Would be interesting to compare a GUI test suite against the driver and ORM ones

@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@ozturkberkay
Copy link

ozturkberkay commented May 2, 2022

Hi. I noticed that pg_cancel_backend is also not supported. Are there any alternatives for pg_terminate_backend and/or pg_cancel_backend in CockroachDB?

EDIT: https://www.cockroachlabs.com/docs/v21.2/cancel-session

@vy-ton
Copy link
Contributor

vy-ton commented May 16, 2022

#41335 is coming in 22.1 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-investigation Further steps needed to qualify. C-label will change. meta-issue Contains a list of several other issues. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
(DEPRECATED) SQL Front-end, Lang & Se...
  
Feature requests / pie-in-the-skie
SQL Sessions - Deprecated
Longer term backlog
Development

No branches or pull requests

7 participants