Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: disallow watching two tables with the same name #32509

Closed
danhhz opened this issue Nov 20, 2018 · 2 comments
Closed

changefeedccl: disallow watching two tables with the same name #32509

danhhz opened this issue Nov 20, 2018 · 2 comments
Assignees
@miretskiy
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
[DEPRECATED] CDC

Comments

@danhhz
Copy link
Contributor

danhhz commented Nov 20, 2018 •
edited by cockroach-jira-scripts

Something like CREATE CHANGEFEED db1.foo, db2.foo ... will currently work, but will output both to the same topic, which is non-sensical. We should error instead. Similar to #30439

Jira issue: CRDB-4740
@danhhz danhhz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture labels Nov 20, 2018
@danhhz danhhz added this to Triage in [DEPRECATED] CDC Dec 5, 2018
@danhhz danhhz moved this from Triage to Later in [DEPRECATED] CDC Feb 5, 2019
@mwang1026 mwang1026 moved this from Later to Bugs in [DEPRECATED] CDC May 29, 2020
@elinorgarcia elinorgarcia added T-cdc and removed A-cdc Change Data Capture labels Dec 7, 2020
@miretskiy miretskiy self-assigned this Mar 16, 2021
@miretskiy miretskiy mentioned this issue Mar 16, 2021
Closed
@mileswilson
Copy link

I'm not sure this is non-sensical in all cases.

If I'm using CDC to power the Message Outbox pattern, so long as the schemas in the table are compatible, it's entirely possible that I have db1.outbox and db2.outbox and want them to end up on a single topic for processing - it means I can centralise the message processing, but distribute the ability to "publish".

@amruss
Copy link
Contributor

amruss commented May 4, 2022

Closing this issue as we've decided for now at least that this is the behavior we want

@amruss amruss closed this as completed May 4, 2022
[DEPRECATED] CDC automation moved this from Bugs to Closed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miretskiy miretskiy

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
[DEPRECATED] CDC
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc: Handle changefeed over multiple tables with the same name. miretskiy/cockroach
6 participants
@danhhz @jlinder @mileswilson @amruss @miretskiy @elinorgarcia